oss/miniflux-v2
oss/miniflux-v2
1
0
Fork 0
mirror of https://github.com/miniflux/v2.git synced 2025-06-27 16:36:00 +00:00
Code Wiki Activity

refactor(subscription): use strings.HasSuffix instead of a regex in FindSubscriptionsFromYouTubePlaylistPage

Browse source
This commit is contained in:
Julien Voisin 2024-12-10 01:19:28 +00:00 • committed by GitHub
parent 728423339a
commit 02c6d14659
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
internal/reader/subscription/finder.go
View file

@ -25,7 +25,6 @@ import (
) )
var ( var (
youtubeHostRegex = regexp.MustCompile(`youtube\.com$`)
youtubeChannelRegex = regexp.MustCompile(`channel/(.*)$`) youtubeChannelRegex = regexp.MustCompile(`channel/(.*)$`)
) )
@ -284,7 +283,7 @@ func (f *SubscriptionFinder) FindSubscriptionsFromYouTubeChannelPage(websiteURL
return nil, locale.NewLocalizedErrorWrapper(err, "error.invalid_site_url", err) return nil, locale.NewLocalizedErrorWrapper(err, "error.invalid_site_url", err)
} }
if !youtubeHostRegex.MatchString(decodedUrl.Host) { if !strings.HasSuffix(decodedUrl.Host, "youtube.com") {
slog.Debug("This website is not a YouTube page, the regex doesn't match", slog.String("website_url", websiteURL)) slog.Debug("This website is not a YouTube page, the regex doesn't match", slog.String("website_url", websiteURL))
return nil, nil return nil, nil
} }
@ -303,7 +302,7 @@ func (f *SubscriptionFinder) FindSubscriptionsFromYouTubePlaylistPage(websiteURL
return nil, locale.NewLocalizedErrorWrapper(err, "error.invalid_site_url", err) return nil, locale.NewLocalizedErrorWrapper(err, "error.invalid_site_url", err)
} }
if !youtubeHostRegex.MatchString(decodedUrl.Host) { if !strings.HasSuffix(decodedUrl.Host, "youtube.com") {
slog.Debug("This website is not a YouTube page, the regex doesn't match", slog.String("website_url", websiteURL)) slog.Debug("This website is not a YouTube page, the regex doesn't match", slog.String("website_url", websiteURL))
return nil, nil return nil, nil
} }