From 02c6d146599193098b19a64bc60b51f16a81bed1 Mon Sep 17 00:00:00 2001 From: Julien Voisin Date: Tue, 10 Dec 2024 01:19:28 +0000 Subject: [PATCH] refactor(subscription): use `strings.HasSuffix` instead of a regex in `FindSubscriptionsFromYouTubePlaylistPage` --- internal/reader/subscription/finder.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/internal/reader/subscription/finder.go b/internal/reader/subscription/finder.go index 945fd1c6..514b7ffc 100644 --- a/internal/reader/subscription/finder.go +++ b/internal/reader/subscription/finder.go @@ -25,7 +25,6 @@ import ( ) var ( - youtubeHostRegex = regexp.MustCompile(`youtube\.com$`) youtubeChannelRegex = regexp.MustCompile(`channel/(.*)$`) ) @@ -284,7 +283,7 @@ func (f *SubscriptionFinder) FindSubscriptionsFromYouTubeChannelPage(websiteURL return nil, locale.NewLocalizedErrorWrapper(err, "error.invalid_site_url", err) } - if !youtubeHostRegex.MatchString(decodedUrl.Host) { + if !strings.HasSuffix(decodedUrl.Host, "youtube.com") { slog.Debug("This website is not a YouTube page, the regex doesn't match", slog.String("website_url", websiteURL)) return nil, nil } @@ -303,7 +302,7 @@ func (f *SubscriptionFinder) FindSubscriptionsFromYouTubePlaylistPage(websiteURL return nil, locale.NewLocalizedErrorWrapper(err, "error.invalid_site_url", err) } - if !youtubeHostRegex.MatchString(decodedUrl.Host) { + if !strings.HasSuffix(decodedUrl.Host, "youtube.com") { slog.Debug("This website is not a YouTube page, the regex doesn't match", slog.String("website_url", websiteURL)) return nil, nil }