mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2025-06-27 16:35:57 +00:00
b2c4fc9f94
* Add the `notify-email` column / NotifyEmail to ActionRun and set it: * services/actions/workflows.go `Dispatch` * services/actions/schedule_tasks.go `CreateScheduleTask` * services/actions/notifier_helper.go `handleWorkflows` * Only send an email if the workflow has `enable-email-notifications: true` by having `MailActionRun` return immediately if `NotifyEmail` is false. * Ignore or silently fail on `enable-email-notifications: true` parsing errors. Reporting such errors belongs in workflow validation, not when it is evaluated for the notifications. * Add unit and integration tests. Refs: https://codeberg.org/forgejo/forgejo/issues/8187 ## Checklist The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org). ### Tests - I added test coverage for Go changes... - [x] in their respective `*_test.go` for unit tests. - [x] in the `tests/integration` directory if it involves interactions with a live Forgejo server. ### Documentation - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [x] I do not want this change to show in the release notes. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/8242 Reviewed-by: Christopher Besch <mail@chris-besch.com> Co-authored-by: Earl Warren <contact@earl-warren.org> Co-committed-by: Earl Warren <contact@earl-warren.org> |
||
|---|---|---|
| .. | ||
| v1_20 | ||
| v1_22 | ||
| main_test.go | ||
| migrate.go | ||
| migrate_test.go | ||
| v13.go | ||
| v14.go | ||
| v15.go | ||
| v16.go | ||
| v17.go | ||
| v18.go | ||
| v19.go | ||
| v20.go | ||
| v21.go | ||
| v22.go | ||
| v23.go | ||
| v24.go | ||
| v25.go | ||
| v25_test.go | ||
| v26.go | ||
| v27.go | ||
| v28.go | ||
| v29.go | ||
| v30.go | ||
| v30_test.go | ||
| v31.go | ||
| v31_test.go | ||
| v32.go | ||
| v32_test.go | ||
| v33.go | ||
| v33_test.go | ||
| v34.go | ||