oss/forgejo-runner
oss/forgejo-runner
1
0
Fork 0
mirror of https://code.forgejo.org/forgejo/runner.git synced 2025-09-05 18:40:59 +00:00
Code Wiki Activity

test: remove internal timeout in TestRunnerCacheConfiguration (#906)

Browse source 
Performance has been in the range of 2.5 - 3 minutes for the "runner integration tests" step, causing this arbitrary timeout to be hit.  The timeout was useful for early test development when nothing was running successfully, but meaningful now.

Fixes #905.

<!--start release-notes-assistant-->
<!--URL:https://code.forgejo.org/forgejo/runner-->
- other
  - [PR](https://code.forgejo.org/forgejo/runner/pulls/906): <!--number 906 --><!--line 0 --><!--description dGVzdDogcmVtb3ZlIGludGVybmFsIHRpbWVvdXQgaW4gVGVzdFJ1bm5lckNhY2hlQ29uZmlndXJhdGlvbg==-->test: remove internal timeout in TestRunnerCacheConfiguration<!--description-->
<!--end release-notes-assistant-->

Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/906
Reviewed-by: earl-warren <earl-warren@noreply.code.forgejo.org>
Co-authored-by: Mathieu Fenniak <mathieu@fenniak.net>
Co-committed-by: Mathieu Fenniak <mathieu@fenniak.net>
This commit is contained in:
Mathieu Fenniak 2025-08-22 05:09:36 +00:00 • committed by earl-warren
parent fac8be3c56
commit 086a8f9847
No known key found for this signature in database
GPG key ID: F128CBE6AB3A7201
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
internal/app/run/runner_test.go
View file

@ -171,7 +171,7 @@ func TestRunnerCacheConfiguration(t *testing.T) {
// Must set up cache for our test
require.NotNil(t, runner.cacheProxy)
ctx, cancel := context.WithTimeout(context.Background(), 3*time.Minute)
ctx, cancel := context.WithCancel(t.Context())
defer cancel()
// Run a given workflow w/ event...