From 086a8f9847b2eb326dfb8b07507326225a7a384c Mon Sep 17 00:00:00 2001 From: Mathieu Fenniak Date: Fri, 22 Aug 2025 05:09:36 +0000 Subject: [PATCH] test: remove internal timeout in TestRunnerCacheConfiguration (#906) Performance has been in the range of 2.5 - 3 minutes for the "runner integration tests" step, causing this arbitrary timeout to be hit. The timeout was useful for early test development when nothing was running successfully, but meaningful now. Fixes #905. - other - [PR](https://code.forgejo.org/forgejo/runner/pulls/906): test: remove internal timeout in TestRunnerCacheConfiguration Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/906 Reviewed-by: earl-warren Co-authored-by: Mathieu Fenniak Co-committed-by: Mathieu Fenniak --- internal/app/run/runner_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/app/run/runner_test.go b/internal/app/run/runner_test.go index 3c983a32..94e476f4 100644 --- a/internal/app/run/runner_test.go +++ b/internal/app/run/runner_test.go @@ -171,7 +171,7 @@ func TestRunnerCacheConfiguration(t *testing.T) { // Must set up cache for our test require.NotNil(t, runner.cacheProxy) - ctx, cancel := context.WithTimeout(context.Background(), 3*time.Minute) + ctx, cancel := context.WithCancel(t.Context()) defer cancel() // Run a given workflow w/ event...