Merge pull request #6 from cjhskippy/ci-fact-dictionary

Fix CI for fact dictionary (?)

.github/workflows/run-fact-dictionary-tests.yml

@@ -6,6 +6,7 @@ on:
       - '/direct-file/backend/src/main/resources/tax/**'
       - '/direct-file/backend/src/test/**'
       - '/direct-file/df-client/df-client-app/src/test/**'
+      - '/.github/workflows/run-fact-dictionary-tests.yml'
     branches:
       - '**'
   pull_request:
@@ -13,6 +14,7 @@ on:
       - '/direct-file/backend/src/main/resources/tax/**'
       - '/direct-file/backend/src/test/**'
       - '/direct-file/df-client/df-client-app/src/test/**'
+      - '/.github/workflows/run-fact-dictionary-tests.yml'
     branches: [main]
 
 jobs:
@@ -34,7 +36,8 @@ jobs:
           node-version: '18.20.4'
 
       - name: Install node
-        uses: ../../../npm install
+        run: npm install
+        working-directory: /direct-file/df-client
 
       - name: Run fact dictionary tests
         run: npm run test factDictionaryTests

direct-file/backend/src/main/resources/tax/constants.xml

@@ -198,7 +198,7 @@
 
     <Fact path="/majorityOfDaysInYear">
       <Name>Majority of days in year</Name>
-      <Description>More than 6 months. This should be changed to 184 in a leap year</Description>
+      <Description>More than 6 months. Most years this is 183 days, but it's 184 in a leap year</Description>
       <TaxYear>2024</TaxYear>
       <Derived>
         <Switch>
@@ -223,7 +223,7 @@
     </Fact>
 
     <Fact path="/minorityOfDaysInYear">
-      <Description>Less than 6 months. This may need to manually change in a leap year.</Description>
+      <Description>Less than 6 months. Most years this is 182 days, but it's 183 in a leap year.</Description>
       <Derived>
         <Subtract>
           <Minuend>
@@ -934,7 +934,7 @@
     <Fact path="/apfForm1099MiscPayerEin">
       <Description>The EIN of the payer on the 1099-Misc form for the Alaska Permanent Fund Dividend.</Description>
       <Derived>
-        <!--      The alaskaPFD (https://pfd.alaska.gov/payments/tax-information) Federal Tax Identification number is 92-6001185-->
+        <!-- The alaskaPFD (https://pfd.alaska.gov/payments/tax-information) Federal Tax Identification number is 92-6001185 -->
         <EIN>926001185</EIN>
       </Derived>
     </Fact>