From b02023237a0f6fb8ce1d3ac90b11a3001d808d82 Mon Sep 17 00:00:00 2001 From: Skippy Williams Date: Fri, 20 Jun 2025 23:21:09 -0700 Subject: [PATCH 1/6] Correct some comments ...and hopefully trigger CI testing of the fact dictionary --- direct-file/backend/src/main/resources/tax/constants.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/direct-file/backend/src/main/resources/tax/constants.xml b/direct-file/backend/src/main/resources/tax/constants.xml index bd802ac..f53091a 100644 --- a/direct-file/backend/src/main/resources/tax/constants.xml +++ b/direct-file/backend/src/main/resources/tax/constants.xml @@ -198,7 +198,7 @@ Majority of days in year - More than 6 months. This should be changed to 184 in a leap year + More than 6 months. Most years this is 183 days, but it's 184 in a leap year 2024 @@ -223,7 +223,7 @@ - Less than 6 months. This may need to manually change in a leap year. + Less than 6 months. Most years this is 182 days, but it's 183 in a leap year. From 1af1d908acf9101fe3c2aba26150443daad3e649 Mon Sep 17 00:00:00 2001 From: Skippy Williams Date: Fri, 20 Jun 2025 23:23:19 -0700 Subject: [PATCH 2/6] Fix CI syntax --- .github/workflows/run-fact-dictionary-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/run-fact-dictionary-tests.yml b/.github/workflows/run-fact-dictionary-tests.yml index ed00ae3..b0530a6 100644 --- a/.github/workflows/run-fact-dictionary-tests.yml +++ b/.github/workflows/run-fact-dictionary-tests.yml @@ -34,7 +34,7 @@ jobs: node-version: '18.20.4' - name: Install node - uses: ../../../npm install + run: ../../../npm install - name: Run fact dictionary tests run: npm run test factDictionaryTests From 2d633c0ba1b9de525789f3f973bdd615337f15b6 Mon Sep 17 00:00:00 2001 From: Skippy Williams Date: Fri, 20 Jun 2025 23:26:03 -0700 Subject: [PATCH 3/6] Trigger CI to re-run on changes to CI script --- .github/workflows/run-fact-dictionary-tests.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/run-fact-dictionary-tests.yml b/.github/workflows/run-fact-dictionary-tests.yml index b0530a6..49377bc 100644 --- a/.github/workflows/run-fact-dictionary-tests.yml +++ b/.github/workflows/run-fact-dictionary-tests.yml @@ -6,6 +6,7 @@ on: - '/direct-file/backend/src/main/resources/tax/**' - '/direct-file/backend/src/test/**' - '/direct-file/df-client/df-client-app/src/test/**' + - '/.github/workflows/run-fact-dictionary-tests.yml' branches: - '**' pull_request: @@ -13,6 +14,7 @@ on: - '/direct-file/backend/src/main/resources/tax/**' - '/direct-file/backend/src/test/**' - '/direct-file/df-client/df-client-app/src/test/**' + - '/.github/workflows/run-fact-dictionary-tests.yml' branches: [main] jobs: From 38864908d8c42eff45540831ea6d67a934f1a7c0 Mon Sep 17 00:00:00 2001 From: Skippy Williams Date: Fri, 20 Jun 2025 23:28:13 -0700 Subject: [PATCH 4/6] Revert "Trigger CI to re-run on changes to CI script" This reverts commit 2d633c0ba1b9de525789f3f973bdd615337f15b6. --- .github/workflows/run-fact-dictionary-tests.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/run-fact-dictionary-tests.yml b/.github/workflows/run-fact-dictionary-tests.yml index 49377bc..b0530a6 100644 --- a/.github/workflows/run-fact-dictionary-tests.yml +++ b/.github/workflows/run-fact-dictionary-tests.yml @@ -6,7 +6,6 @@ on: - '/direct-file/backend/src/main/resources/tax/**' - '/direct-file/backend/src/test/**' - '/direct-file/df-client/df-client-app/src/test/**' - - '/.github/workflows/run-fact-dictionary-tests.yml' branches: - '**' pull_request: @@ -14,7 +13,6 @@ on: - '/direct-file/backend/src/main/resources/tax/**' - '/direct-file/backend/src/test/**' - '/direct-file/df-client/df-client-app/src/test/**' - - '/.github/workflows/run-fact-dictionary-tests.yml' branches: [main] jobs: From eb6cc102c4e1d9f900ddac787fb89871051fb175 Mon Sep 17 00:00:00 2001 From: Skippy Williams Date: Fri, 20 Jun 2025 23:41:51 -0700 Subject: [PATCH 5/6] Fix working directory issue Also try to re-run the tests on changes to the workflow file. I may have forgotten to push the last time. --- .github/workflows/run-fact-dictionary-tests.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/run-fact-dictionary-tests.yml b/.github/workflows/run-fact-dictionary-tests.yml index b0530a6..f63bd39 100644 --- a/.github/workflows/run-fact-dictionary-tests.yml +++ b/.github/workflows/run-fact-dictionary-tests.yml @@ -6,6 +6,7 @@ on: - '/direct-file/backend/src/main/resources/tax/**' - '/direct-file/backend/src/test/**' - '/direct-file/df-client/df-client-app/src/test/**' + - '/.github/workflows/run-fact-dictionary-tests.yml' branches: - '**' pull_request: @@ -13,6 +14,7 @@ on: - '/direct-file/backend/src/main/resources/tax/**' - '/direct-file/backend/src/test/**' - '/direct-file/df-client/df-client-app/src/test/**' + - '/.github/workflows/run-fact-dictionary-tests.yml' branches: [main] jobs: @@ -34,7 +36,8 @@ jobs: node-version: '18.20.4' - name: Install node - run: ../../../npm install + run: npm install + working-directory: /direct-file/df-client - name: Run fact dictionary tests run: npm run test factDictionaryTests From c16c05e79bb3a1cb4d6dd7766c4e2ac444cc1c5a Mon Sep 17 00:00:00 2001 From: Skippy Williams Date: Fri, 20 Jun 2025 23:47:23 -0700 Subject: [PATCH 6/6] Whitespace changes Hoping to trigger a github action --- direct-file/backend/src/main/resources/tax/constants.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/direct-file/backend/src/main/resources/tax/constants.xml b/direct-file/backend/src/main/resources/tax/constants.xml index f53091a..b4e29cd 100644 --- a/direct-file/backend/src/main/resources/tax/constants.xml +++ b/direct-file/backend/src/main/resources/tax/constants.xml @@ -934,7 +934,7 @@ The EIN of the payer on the 1099-Misc form for the Alaska Permanent Fund Dividend. - + 926001185