1
0
Fork 0
mirror of https://github.com/wallabag/wallabag.git synced 2025-09-15 18:57:05 +00:00

Entries filter on language

+ updated deps
This commit is contained in:
Jeremy Benoist 2015-09-23 07:55:55 +02:00
parent 0d3bafdfdf
commit d4ebe5c5dc
8 changed files with 255 additions and 65 deletions

View file

@ -192,7 +192,7 @@ class EntryController extends Controller
throw new \InvalidArgumentException(sprintf('Type "%s" is not implemented.', $type));
}
$form = $this->get('form.factory')->create(new EntryFilterType());
$form = $this->get('form.factory')->create(new EntryFilterType($repository, $this->getUser()));
if ($request->query->has($form->getName())) {
// manually bind values from the request

View file

@ -19,6 +19,7 @@ class LoadEntryData extends AbstractFixture implements OrderedFixtureInterface
$entry1->setUrl('http://0.0.0.0');
$entry1->setTitle('test title entry1');
$entry1->setContent('This is my content /o/');
$entry1->setLanguage('en');
$manager->persist($entry1);
@ -28,6 +29,7 @@ class LoadEntryData extends AbstractFixture implements OrderedFixtureInterface
$entry2->setUrl('http://0.0.0.0');
$entry2->setTitle('test title entry2');
$entry2->setContent('This is my content /o/');
$entry2->setLanguage('fr');
$manager->persist($entry2);
@ -37,6 +39,7 @@ class LoadEntryData extends AbstractFixture implements OrderedFixtureInterface
$entry3->setUrl('http://0.0.0.0');
$entry3->setTitle('test title entry3');
$entry3->setContent('This is my content /o/');
$entry3->setLanguage('en');
$tag1 = new Tag($this->getReference('bob-user'));
$tag1->setLabel('foo');
@ -54,6 +57,7 @@ class LoadEntryData extends AbstractFixture implements OrderedFixtureInterface
$entry4->setUrl('http://0.0.0.0');
$entry4->setTitle('test title entry4');
$entry4->setContent('This is my content /o/');
$entry4->setLanguage('en');
$tag1 = new Tag($this->getReference('admin-user'));
$tag1->setLabel('foo');
@ -72,6 +76,7 @@ class LoadEntryData extends AbstractFixture implements OrderedFixtureInterface
$entry5->setTitle('test title entry5');
$entry5->setContent('This is my content /o/');
$entry5->setStarred(true);
$entry5->setLanguage('fr');
$manager->persist($entry5);
@ -82,6 +87,7 @@ class LoadEntryData extends AbstractFixture implements OrderedFixtureInterface
$entry6->setTitle('test title entry6');
$entry6->setContent('This is my content /o/');
$entry6->setArchived(true);
$entry6->setLanguage('de');
$manager->persist($entry6);

View file

@ -6,9 +6,26 @@ use Symfony\Component\Form\AbstractType;
use Symfony\Component\Form\FormBuilderInterface;
use Symfony\Component\OptionsResolver\OptionsResolver;
use Lexik\Bundle\FormFilterBundle\Filter\Query\QueryInterface;
use Doctrine\ORM\EntityRepository;
use Wallabag\CoreBundle\Entity\User;
class EntryFilterType extends AbstractType
{
private $user;
private $repository;
/**
* Repository & user are used to get a list of language entries for this user
*
* @param EntityRepository $entryRepository
* @param User $user
*/
public function __construct(EntityRepository $entryRepository, User $user)
{
$this->repository = $entryRepository;
$this->user = $user;
}
public function buildForm(FormBuilderInterface $builder, array $options)
{
$builder
@ -53,7 +70,11 @@ class EntryFilterType extends AbstractType
return $filterQuery->createCondition($expression);
},
));
))
->add('language', 'filter_choice', array(
'choices' => $this->repository->findDistinctLanguageByUser($this->user->getId()),
))
;
}
public function getName()

View file

@ -134,4 +134,31 @@ class EntryRepository extends EntityRepository
return $qb->getQuery()->getResult();
}
/**
* Find distinct language for a given user.
* Used to build the filter language list.
*
* @param int $userId User id
*
* @return array
*/
public function findDistinctLanguageByUser($userId)
{
$results = $this->createQueryBuilder('e')
->select('e.language')
->where('e.user = :userId')->setParameter('userId', $userId)
->andWhere('e.language IS NOT NULL')
->groupBy('e.language')
->orderBy('e.language', ' ASC')
->getQuery()
->getResult();
$languages = array();
foreach ($results as $result) {
$languages[$result['language']] = $result['language'];
}
return $languages;
}
}

View file

@ -71,6 +71,14 @@
<label for="entry_filter_previewPicture">{% trans %}Has a preview picture{% endtrans %}</label>
</div>
</div>
<div id="filter-language" class="filter-group">
<label for="entry_filter_language">{% trans %}Language{% endtrans %}</label>
<div class="input-field ">
{{ form_widget(form.language) }}
</div>
</div>
<div id="filter-reading-time" class="filter-group">
<div class="">
<label>{% trans %}Reading time in minutes{% endtrans %}</label>

View file

@ -121,14 +121,12 @@
<label for="entry_filter_previewPicture">{% trans %}Has a preview picture{% endtrans %}</label>
</div>
<div class="input-field col s6">
{{ form_widget(form.isArchived) }}
<label for="entry_filter_isArchived">{% trans %}Archived{% endtrans %}</label>
<div class="col s12">
<label>{% trans %}Language{% endtrans %}</label>
</div>
<div class="input-field col s6">
{{ form_widget(form.isStarred) }}
<label for="entry_filter_isStarred">{% trans %}Starred{% endtrans %}</label>
<div class="input-field col s12">
{{ form_widget(form.language) }}
</div>
<div class="col s12">

View file

@ -382,4 +382,27 @@ class EntryControllerTest extends WallabagCoreTestCase
$crawler = $client->submit($form);
$this->assertCount(1, $crawler->filter('div[class=entry]'));
}
public function testFilterOnLanguage()
{
$this->logInAs('admin');
$client = $this->getClient();
$crawler = $client->request('GET', '/unread/list');
$form = $crawler->filter('button[id=submit-filter]')->form();
$data = array(
'entry_filter[language]' => 'de',
);
$crawler = $client->submit($form, $data);
$this->assertCount(1, $crawler->filter('div[class=entry]'));
$form = $crawler->filter('button[id=submit-filter]')->form();
$data = array(
'entry_filter[language]' => 'en',
);
$crawler = $client->submit($form, $data);
$this->assertCount(2, $crawler->filter('div[class=entry]'));
}
}