oss/wallabag
oss/wallabag
1
0
Fork 0
mirror of https://github.com/wallabag/wallabag.git synced 2025-09-30 19:22:12 +00:00
Code Wiki Activity

Fix async browser import with nested children

Browse source 
The `parseEntry` function recurses into children and dispatches their processing. However, validate will reject any entry that does not have a url e.g. parents.

We need to call parseEntries before so that the processing of children is dispatched, otherwise nothing is imported.
This commit is contained in:
Nikos Tsipinakis 2025-08-09 17:19:13 +02:00 • committed by GitHub
parent efaa129ef1
commit ce731bc987
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/Consumer/AbstractConsumer.php
View file

@ -46,6 +46,8 @@ abstract class AbstractConsumer
$this->import->setUser($user); $this->import->setUser($user);
$entry = $this->import->parseEntry($storedEntry);
if (false === $this->import->validateEntry($storedEntry)) { if (false === $this->import->validateEntry($storedEntry)) {
$this->logger->warning('Entry is invalid', ['entry' => $storedEntry]); $this->logger->warning('Entry is invalid', ['entry' => $storedEntry]);
@ -53,8 +55,6 @@ abstract class AbstractConsumer
return true; return true;
} }
$entry = $this->import->parseEntry($storedEntry);
if (null === $entry) { if (null === $entry) {
$this->logger->warning('Entry already exists', ['entry' => $storedEntry]); $this->logger->warning('Entry already exists', ['entry' => $storedEntry]);