oss/wallabag
oss/wallabag
1
0
Fork 0
mirror of https://github.com/wallabag/wallabag.git synced 2025-07-22 17:18:37 +00:00
Code Wiki Activity

Remove ability to change username

Browse source 
Since password are linked to username it was hard to change username while checking that the password is the good one.

Instead of doing crazy things to achieve that, I act that user won't be able to update username.

Also, username (and email) must be unique, since people logged in using username and can request a new password using email.

This should fix #1149
This commit is contained in:
Jeremy 2015-03-28 00:10:39 +01:00
parent 1a93ee423b
commit c844dc0c50
5 changed files with 25 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

37
src/Wallabag/CoreBundle/Tests/Controller/ConfigControllerTest.php
View file

@ -27,7 +27,7 @@ class ConfigControllerTest extends WallabagTestCase
$this->assertCount(1, $crawler->filter('button[id=config_save]'));
$this->assertCount(1, $crawler->filter('button[id=change_passwd_save]'));
$this->assertCount(1, $crawler->filter('button[id=user_save]'));
$this->assertCount(1, $crawler->filter('button[id=update_user_save]'));
$this->assertCount(1, $crawler->filter('button[id=new_user_save]'));
$this->assertCount(1, $crawler->filter('button[id=rss_config_save]'));
}
@ -189,25 +189,15 @@ class ConfigControllerTest extends WallabagTestCase
return array(
array(
array(
'user[username]' => '',
'user[name]' => '',
'user[email]' => '',
'update_user[name]' => '',
'update_user[email]' => '',
),
'This value should not be blank.',
),
array(
array(
'user[username]' => 'ad',
'user[name]' => '',
'user[email]' => '',
),
'This value is too short.',
),
array(
array(
'user[username]' => 'admin',
'user[name]' => '',
'user[email]' => 'test',
'update_user[name]' => '',
'update_user[email]' => 'test',
),
'This value is not a valid email address.',
),
@ -226,7 +216,7 @@ class ConfigControllerTest extends WallabagTestCase
$this->assertEquals(200, $client->getResponse()->getStatusCode());
$form = $crawler->filter('button[id=user_save]')->form();
$form = $crawler->filter('button[id=update_user_save]')->form();
$crawler = $client->submit($form, $data);
@ -245,12 +235,11 @@ class ConfigControllerTest extends WallabagTestCase
$this->assertEquals(200, $client->getResponse()->getStatusCode());
$form = $crawler->filter('button[id=user_save]')->form();
$form = $crawler->filter('button[id=update_user_save]')->form();
$data = array(
'user[username]' => 'admin',
'user[name]' => 'new name',
'user[email]' => 'admin@wallabag.io',
'update_user[name]' => 'new name',
'update_user[email]' => 'admin@wallabag.io',
);
$client->submit($form, $data);
@ -298,6 +287,14 @@ class ConfigControllerTest extends WallabagTestCase
),
'Password should by at least',
),
array(
array(
'new_user[username]' => 'admin',
'new_user[password]' => 'wallacewallace',
'new_user[email]' => 'wallace@wallace.me',
),
'This value is already used',
),
);
}