1
0
Fork 0
mirror of https://github.com/wallabag/wallabag.git synced 2025-07-22 17:18:37 +00:00

Fix relations export for Entry

Tags & Annotations weren’t really well exported.
This is now fixed (+ tests)
This commit is contained in:
Jeremy Benoist 2016-10-02 16:06:42 +02:00
parent 9d127b3b93
commit b0458874c8
No known key found for this signature in database
GPG key ID: BCA73962457ACC3C
5 changed files with 58 additions and 19 deletions

View file

@ -7,6 +7,7 @@ use JMS\Serializer\Annotation\ExclusionPolicy;
use JMS\Serializer\Annotation\Exclude;
use JMS\Serializer\Annotation\VirtualProperty;
use JMS\Serializer\Annotation\SerializedName;
use JMS\Serializer\Annotation\Groups;
use Wallabag\UserBundle\Entity\User;
use Wallabag\CoreBundle\Entity\Entry;
@ -33,6 +34,8 @@ class Annotation
* @var string
*
* @ORM\Column(name="text", type="text")
*
* @Groups({"entries_for_user", "export_all"})
*/
private $text;
@ -54,6 +57,8 @@ class Annotation
* @var string
*
* @ORM\Column(name="quote", type="string")
*
* @Groups({"entries_for_user", "export_all"})
*/
private $quote;
@ -61,6 +66,8 @@ class Annotation
* @var array
*
* @ORM\Column(name="ranges", type="array")
*
* @Groups({"entries_for_user", "export_all"})
*/
private $ranges;

View file

@ -23,6 +23,9 @@ class LoadEntryData extends AbstractFixture implements OrderedFixtureInterface
$entry1->setContent('This is my content /o/');
$entry1->setLanguage('en');
$entry1->addTag($this->getReference('foo-tag'));
$entry1->addTag($this->getReference('baz-tag'));
$manager->persist($entry1);
$this->addReference('entry1', $entry1);
@ -96,6 +99,7 @@ class LoadEntryData extends AbstractFixture implements OrderedFixtureInterface
$entry6->setContent('This is my content /o/');
$entry6->setArchived(true);
$entry6->setLanguage('de');
$entry6->addTag($this->getReference('bar-tag'));
$manager->persist($entry6);

View file

@ -196,8 +196,6 @@ class Entry
* @ORM\JoinColumn(name="tag_id", referencedColumnName="id")
* }
* )
*
* @Groups({"entries_for_user", "export_all"})
*/
private $tags;
@ -541,6 +539,21 @@ class Entry
return $this->tags;
}
/**
* @VirtualProperty
* @SerializedName("tags")
* @Groups({"entries_for_user", "export_all"})
*/
public function getSerializedTags()
{
$data = [];
foreach ($this->tags as $tag) {
$data[] = $tag->getLabel();
}
return $data;
}
/**
* @param Tag $tag
*/

View file

@ -53,10 +53,6 @@ class EntriesExport
$this->entries = $entries;
foreach ($entries as $entry) {
$this->tags[] = $entry->getTags();
}
return $this;
}
@ -159,8 +155,8 @@ class EntriesExport
// set tags as subjects
foreach ($this->entries as $entry) {
foreach ($this->tags as $tag) {
$book->setSubject($tag['value']);
foreach ($entry->getTags() as $tag) {
$book->setSubject($tag->getLabel());
}
// the reader in Kobo Devices doesn't likes special caracters
@ -265,8 +261,8 @@ class EntriesExport
* Adding actual entries
*/
foreach ($this->entries as $entry) {
foreach ($this->tags as $tag) {
$pdf->SetKeywords($tag['value']);
foreach ($entry->getTags() as $tag) {
$pdf->SetKeywords($tag->getLabel());
}
$pdf->AddPage();