1
0
Fork 0
mirror of https://github.com/wallabag/wallabag.git synced 2025-08-06 17:41:01 +00:00

Merge pull request #7967 from wallabag/fix-some-deprecation-notices

Fix some deprecation notices
This commit is contained in:
Kevin Decherf 2025-01-19 15:46:45 +01:00 committed by GitHub
commit 7f340f83d2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
56 changed files with 88 additions and 80 deletions

View file

@ -11,7 +11,7 @@ use Wallabag\Entity\User;
class AnnotationFixtures extends Fixture implements DependentFixtureInterface class AnnotationFixtures extends Fixture implements DependentFixtureInterface
{ {
public function load(ObjectManager $manager) public function load(ObjectManager $manager): void
{ {
$annotation1 = new Annotation($this->getReference('admin-user', User::class)); $annotation1 = new Annotation($this->getReference('admin-user', User::class));
$annotation1->setEntry($this->getReference('entry1', Entry::class)); $annotation1->setEntry($this->getReference('entry1', Entry::class));

View file

@ -8,7 +8,7 @@ use Wallabag\Entity\User;
class UserFixtures extends Fixture class UserFixtures extends Fixture
{ {
public function load(ObjectManager $manager) public function load(ObjectManager $manager): void
{ {
$userAdmin = new User(); $userAdmin = new User();
$userAdmin->setName('Big boss'); $userAdmin->setName('Big boss');

View file

@ -38,7 +38,7 @@ class CleanDownloadedImagesCommand extends Command
); );
} }
protected function execute(InputInterface $input, OutputInterface $output) protected function execute(InputInterface $input, OutputInterface $output): int
{ {
$io = new SymfonyStyle($input, $output); $io = new SymfonyStyle($input, $output);

View file

@ -45,7 +45,7 @@ class CleanDuplicatesCommand extends Command
); );
} }
protected function execute(InputInterface $input, OutputInterface $output) protected function execute(InputInterface $input, OutputInterface $output): int
{ {
$this->io = new SymfonyStyle($input, $output); $this->io = new SymfonyStyle($input, $output);

View file

@ -49,7 +49,7 @@ class ExportCommand extends Command
; ;
} }
protected function execute(InputInterface $input, OutputInterface $output) protected function execute(InputInterface $input, OutputInterface $output): int
{ {
$io = new SymfonyStyle($input, $output); $io = new SymfonyStyle($input, $output);

View file

@ -39,7 +39,7 @@ class GenerateUrlHashesCommand extends Command
->addArgument('username', InputArgument::OPTIONAL, 'User to process entries'); ->addArgument('username', InputArgument::OPTIONAL, 'User to process entries');
} }
protected function execute(InputInterface $input, OutputInterface $output) protected function execute(InputInterface $input, OutputInterface $output): int
{ {
$this->output = $output; $this->output = $output;

View file

@ -97,7 +97,7 @@ class ImportCommand extends Command
; ;
} }
protected function execute(InputInterface $input, OutputInterface $output) protected function execute(InputInterface $input, OutputInterface $output): int
{ {
$output->writeln('Start : ' . (new \DateTime())->format('d-m-Y G:i:s') . ' ---'); $output->writeln('Start : ' . (new \DateTime())->format('d-m-Y G:i:s') . ' ---');
@ -125,7 +125,6 @@ class ImportCommand extends Command
// Authenticate user for paywalled websites // Authenticate user for paywalled websites
$token = new UsernamePasswordToken( $token = new UsernamePasswordToken(
$entityUser, $entityUser,
null,
'main', 'main',
$entityUser->getRoles()); $entityUser->getRoles());

View file

@ -33,7 +33,7 @@ class RedisWorkerCommand extends Command
; ;
} }
protected function execute(InputInterface $input, OutputInterface $output) protected function execute(InputInterface $input, OutputInterface $output): int
{ {
$output->writeln('Worker started at: ' . (new \DateTime())->format('d-m-Y G:i:s')); $output->writeln('Worker started at: ' . (new \DateTime())->format('d-m-Y G:i:s'));
$output->writeln('Waiting for message ...'); $output->writeln('Waiting for message ...');

View file

@ -70,7 +70,7 @@ class InstallCommand extends Command
; ;
} }
protected function execute(InputInterface $input, OutputInterface $output) protected function execute(InputInterface $input, OutputInterface $output): int
{ {
$this->defaultInput = $input; $this->defaultInput = $input;

View file

@ -33,7 +33,7 @@ class ListUserCommand extends Command
; ;
} }
protected function execute(InputInterface $input, OutputInterface $output) protected function execute(InputInterface $input, OutputInterface $output): int
{ {
$io = new SymfonyStyle($input, $output); $io = new SymfonyStyle($input, $output);

View file

@ -51,7 +51,7 @@ class ReloadEntryCommand extends Command
); );
} }
protected function execute(InputInterface $input, OutputInterface $output) protected function execute(InputInterface $input, OutputInterface $output): int
{ {
$io = new SymfonyStyle($input, $output); $io = new SymfonyStyle($input, $output);

View file

@ -37,7 +37,7 @@ class ShowUserCommand extends Command
); );
} }
protected function execute(InputInterface $input, OutputInterface $output) protected function execute(InputInterface $input, OutputInterface $output): int
{ {
$this->io = new SymfonyStyle($input, $output); $this->io = new SymfonyStyle($input, $output);

View file

@ -42,7 +42,7 @@ class TagAllCommand extends Command
; ;
} }
protected function execute(InputInterface $input, OutputInterface $output) protected function execute(InputInterface $input, OutputInterface $output): int
{ {
$io = new SymfonyStyle($input, $output); $io = new SymfonyStyle($input, $output);

View file

@ -37,7 +37,7 @@ class UpdatePicturesPathCommand extends Command
); );
} }
protected function execute(InputInterface $input, OutputInterface $output) protected function execute(InputInterface $input, OutputInterface $output): int
{ {
$io = new SymfonyStyle($input, $output); $io = new SymfonyStyle($input, $output);

View file

@ -314,7 +314,7 @@ class EntryRestController extends WallabagRestController
$order = strtolower($request->query->get('order', 'desc')); $order = strtolower($request->query->get('order', 'desc'));
$page = (int) $request->query->get('page', 1); $page = (int) $request->query->get('page', 1);
$perPage = (int) $request->query->get('perPage', 30); $perPage = (int) $request->query->get('perPage', 30);
$tags = \is_array($request->query->get('tags')) ? '' : (string) $request->query->get('tags', ''); $tags = \is_array($request->query->all()['tags'] ?? '') ? '' : (string) $request->query->get('tags', '');
$since = $request->query->get('since', 0); $since = $request->query->get('since', 0);
$detail = strtolower($request->query->get('detail', 'full')); $detail = strtolower($request->query->get('detail', 'full'));
$domainName = (null === $request->query->get('domain_name')) ? '' : (string) $request->query->get('domain_name'); $domainName = (null === $request->query->get('domain_name')) ? '' : (string) $request->query->get('domain_name');
@ -477,7 +477,7 @@ class EntryRestController extends WallabagRestController
{ {
$this->validateAuthentication(); $this->validateAuthentication();
$urls = json_decode($request->query->get('urls', [])); $urls = json_decode($request->query->get('urls', '[]'));
if (empty($urls)) { if (empty($urls)) {
return $this->sendResponse([]); return $this->sendResponse([]);
@ -537,7 +537,7 @@ class EntryRestController extends WallabagRestController
{ {
$this->validateAuthentication(); $this->validateAuthentication();
$urls = json_decode($request->query->get('urls', [])); $urls = json_decode($request->query->get('urls', '[]'));
$limit = $this->getParameter('wallabag.api_limit_mass_actions'); $limit = $this->getParameter('wallabag.api_limit_mass_actions');
@ -1287,7 +1287,7 @@ class EntryRestController extends WallabagRestController
{ {
$this->validateAuthentication(); $this->validateAuthentication();
$list = json_decode($request->query->get('list', [])); $list = json_decode($request->query->get('list', '[]'));
if (empty($list)) { if (empty($list)) {
return $this->sendResponse([]); return $this->sendResponse([]);
@ -1354,7 +1354,7 @@ class EntryRestController extends WallabagRestController
{ {
$this->validateAuthentication(); $this->validateAuthentication();
$list = json_decode($request->query->get('list', [])); $list = json_decode($request->query->get('list', '[]'));
if (empty($list)) { if (empty($list)) {
return $this->sendResponse([]); return $this->sendResponse([]);
@ -1413,7 +1413,7 @@ class EntryRestController extends WallabagRestController
{ {
return [ return [
'title' => $request->request->get('title'), 'title' => $request->request->get('title'),
'tags' => $request->request->get('tags', []), 'tags' => $request->request->get('tags', ''),
'isArchived' => $request->request->get('archive'), 'isArchived' => $request->request->get('archive'),
'isStarred' => $request->request->get('starred'), 'isStarred' => $request->request->get('starred'),
'isPublic' => $request->request->get('public'), 'isPublic' => $request->request->get('public'),
@ -1421,7 +1421,7 @@ class EntryRestController extends WallabagRestController
'language' => $request->request->get('language'), 'language' => $request->request->get('language'),
'picture' => $request->request->get('preview_picture'), 'picture' => $request->request->get('preview_picture'),
'publishedAt' => $request->request->get('published_at'), 'publishedAt' => $request->request->get('published_at'),
'authors' => $request->request->get('authors', ''), 'authors' => $request->request->all()['authors'] ?? '',
'origin_url' => $request->request->get('origin_url', ''), 'origin_url' => $request->request->get('origin_url', ''),
]; ];
} }

View file

@ -37,7 +37,7 @@ class TaggingRuleRestController extends WallabagRestController
SerializationContext::create()->setGroups(['export_tagging_rule']) SerializationContext::create()->setGroups(['export_tagging_rule'])
); );
return Response::create( return new Response(
$data, $data,
200, 200,
[ [

View file

@ -700,7 +700,7 @@ class ConfigController extends AbstractController
SerializationContext::create()->setGroups(['export_tagging_rule']) SerializationContext::create()->setGroups(['export_tagging_rule'])
); );
return Response::create( return new Response(
$data, $data,
200, 200,
[ [

View file

@ -625,6 +625,7 @@ class EntryController extends AbstractController
{ {
$searchTerm = (isset($request->query->get('search_entry')['term']) ? trim($request->query->get('search_entry')['term']) : ''); $searchTerm = (isset($request->query->get('search_entry')['term']) ? trim($request->query->get('search_entry')['term']) : '');
$currentRoute = (null !== $request->query->get('currentRoute') ? $request->query->get('currentRoute') : ''); $currentRoute = (null !== $request->query->get('currentRoute') ? $request->query->get('currentRoute') : '');
$currentEntryId = $request->attributes->getInt('id');
$formOptions = []; $formOptions = [];
@ -651,7 +652,7 @@ class EntryController extends AbstractController
$formOptions['filter_unread'] = true; $formOptions['filter_unread'] = true;
break; break;
case 'same-domain': case 'same-domain':
$qb = $this->entryRepository->getBuilderForSameDomainByUser($this->getUser()->getId(), $request->get('id')); $qb = $this->entryRepository->getBuilderForSameDomainByUser($this->getUser()->getId(), $currentEntryId);
break; break;
case 'all': case 'all':
$qb = $this->entryRepository->getBuilderForAllByUser($this->getUser()->getId()); $qb = $this->entryRepository->getBuilderForAllByUser($this->getUser()->getId());
@ -664,7 +665,7 @@ class EntryController extends AbstractController
if ($request->query->has($form->getName())) { if ($request->query->has($form->getName())) {
// manually bind values from the request // manually bind values from the request
$form->submit($request->query->get($form->getName())); $form->submit($request->query->all($form->getName()));
// build the query from the given form object // build the query from the given form object
$this->filterBuilderUpdater->addFilterConditions($form, $qb); $this->filterBuilderUpdater->addFilterConditions($form, $qb);

View file

@ -25,12 +25,12 @@ class JsonArrayType extends JsonType
return json_decode($value, true); return json_decode($value, true);
} }
public function getName() public function getName(): string
{ {
return 'json_array'; return 'json_array';
} }
public function requiresSQLCommentHint(AbstractPlatform $platform) public function requiresSQLCommentHint(AbstractPlatform $platform): bool
{ {
return true; return true;
} }

View file

@ -18,7 +18,7 @@ class AuthenticationFailureListener implements EventSubscriberInterface
$this->logger = $logger; $this->logger = $logger;
} }
public static function getSubscribedEvents() public static function getSubscribedEvents(): array
{ {
return [ return [
AuthenticationEvents::AUTHENTICATION_FAILURE => 'onAuthenticationFailure', AuthenticationEvents::AUTHENTICATION_FAILURE => 'onAuthenticationFailure',
@ -30,7 +30,7 @@ class AuthenticationFailureListener implements EventSubscriberInterface
*/ */
public function onAuthenticationFailure() public function onAuthenticationFailure()
{ {
$request = $this->requestStack->getMasterRequest(); $request = $this->requestStack->getMainRequest();
$this->logger->error('Authentication failure for user "' . $request->request->get('_username') . '", from IP "' . $request->getClientIp() . '", with UA: "' . $request->server->get('HTTP_USER_AGENT') . '".'); $this->logger->error('Authentication failure for user "' . $request->request->get('_username') . '", from IP "' . $request->getClientIp() . '", with UA: "' . $request->server->get('HTTP_USER_AGENT') . '".');
} }

View file

@ -38,7 +38,7 @@ class CreateConfigListener implements EventSubscriberInterface
$this->displayThumbnails = $displayThumbnails; $this->displayThumbnails = $displayThumbnails;
} }
public static function getSubscribedEvents() public static function getSubscribedEvents(): array
{ {
return [ return [
// when a user register using the normal form // when a user register using the normal form
@ -53,8 +53,8 @@ class CreateConfigListener implements EventSubscriberInterface
{ {
$language = $this->language; $language = $this->language;
if ($this->requestStack->getMasterRequest()) { if ($this->requestStack->getMainRequest()) {
$session = $this->requestStack->getMasterRequest()->getSession(); $session = $this->requestStack->getMainRequest()->getSession();
$language = $session->get('_locale', $this->language); $language = $session->get('_locale', $this->language);
} }

View file

@ -34,7 +34,7 @@ class LocaleListener implements EventSubscriberInterface
} }
} }
public static function getSubscribedEvents() public static function getSubscribedEvents(): array
{ {
return [ return [
// must be registered before the default Locale listener // must be registered before the default Locale listener

View file

@ -22,7 +22,7 @@ class PasswordResettingListener implements EventSubscriberInterface
$this->router = $router; $this->router = $router;
} }
public static function getSubscribedEvents() public static function getSubscribedEvents(): array
{ {
return [ return [
FOSUserEvents::RESETTING_RESET_SUCCESS => 'onPasswordResettingSuccess', FOSUserEvents::RESETTING_RESET_SUCCESS => 'onPasswordResettingSuccess',

View file

@ -26,7 +26,7 @@ class RegistrationListener implements EventSubscriberInterface
$this->urlGenerator = $urlGenerator; $this->urlGenerator = $urlGenerator;
} }
public static function getSubscribedEvents() public static function getSubscribedEvents(): array
{ {
return [ return [
FOSUserEvents::REGISTRATION_INITIALIZE => 'onRegistrationInitialize', FOSUserEvents::REGISTRATION_INITIALIZE => 'onRegistrationInitialize',

View file

@ -25,7 +25,7 @@ class DownloadImagesSubscriber implements EventSubscriberInterface
$this->logger = $logger; $this->logger = $logger;
} }
public static function getSubscribedEvents() public static function getSubscribedEvents(): array
{ {
return [ return [
EntrySavedEvent::NAME => 'onEntrySaved', EntrySavedEvent::NAME => 'onEntrySaved',

View file

@ -18,7 +18,7 @@ class GenerateCustomCSSSubscriber implements EventSubscriberInterface
$this->compiler = $compiler; $this->compiler = $compiler;
} }
public static function getSubscribedEvents() public static function getSubscribedEvents(): array
{ {
return [ return [
ConfigUpdatedEvent::NAME => 'onConfigUpdated', ConfigUpdatedEvent::NAME => 'onConfigUpdated',

View file

@ -15,7 +15,7 @@ class SchemaAdapterSubscriber implements EventSubscriber
$this->databaseTablePrefix = $databaseTablePrefix; $this->databaseTablePrefix = $databaseTablePrefix;
} }
public function getSubscribedEvents() public function getSubscribedEvents(): array
{ {
return ['postGenerateSchema']; return ['postGenerateSchema'];
} }

View file

@ -25,7 +25,7 @@ class TablePrefixSubscriber implements EventSubscriber
$this->tablePrefix = (string) $tablePrefix; $this->tablePrefix = (string) $tablePrefix;
} }
public function getSubscribedEvents() public function getSubscribedEvents(): array
{ {
return ['loadClassMetadata']; return ['loadClassMetadata'];
} }

View file

@ -45,7 +45,7 @@ class ClientType extends AbstractType
]); ]);
} }
public function getBlockPrefix() public function getBlockPrefix(): string
{ {
return 'client'; return 'client';
} }

View file

@ -41,7 +41,7 @@ class ChangePasswordType extends AbstractType
; ;
} }
public function getBlockPrefix() public function getBlockPrefix(): string
{ {
return 'change_passwd'; return 'change_passwd';
} }

View file

@ -104,7 +104,7 @@ class ConfigType extends AbstractType
]); ]);
} }
public function getBlockPrefix() public function getBlockPrefix(): string
{ {
return 'config'; return 'config';
} }

View file

@ -44,7 +44,7 @@ class EditEntryType extends AbstractType
]); ]);
} }
public function getBlockPrefix() public function getBlockPrefix(): string
{ {
return 'entry'; return 'entry';
} }

View file

@ -197,7 +197,7 @@ class EntryFilterType extends AbstractType
; ;
} }
public function getBlockPrefix() public function getBlockPrefix(): string
{ {
return 'entry_filter'; return 'entry_filter';
} }

View file

@ -30,7 +30,7 @@ class FeedType extends AbstractType
]); ]);
} }
public function getBlockPrefix() public function getBlockPrefix(): string
{ {
return 'feed_config'; return 'feed_config';
} }

View file

@ -31,7 +31,7 @@ class IgnoreOriginInstanceRuleType extends AbstractType
]); ]);
} }
public function getBlockPrefix() public function getBlockPrefix(): string
{ {
return 'ignore_origin_instance_rule'; return 'ignore_origin_instance_rule';
} }

View file

@ -31,7 +31,7 @@ class IgnoreOriginUserRuleType extends AbstractType
]); ]);
} }
public function getBlockPrefix() public function getBlockPrefix(): string
{ {
return 'ignore_origin_user_rule'; return 'ignore_origin_user_rule';
} }

View file

@ -28,7 +28,7 @@ class NewEntryType extends AbstractType
]); ]);
} }
public function getBlockPrefix() public function getBlockPrefix(): string
{ {
return 'entry'; return 'entry';
} }

View file

@ -37,7 +37,7 @@ class NewTagType extends AbstractType
]); ]);
} }
public function getBlockPrefix() public function getBlockPrefix(): string
{ {
return 'tag'; return 'tag';
} }

View file

@ -53,7 +53,7 @@ class NewUserType extends AbstractType
]); ]);
} }
public function getBlockPrefix() public function getBlockPrefix(): string
{ {
return 'new_user'; return 'new_user';
} }

View file

@ -29,7 +29,7 @@ class RenameTagType extends AbstractType
]); ]);
} }
public function getBlockPrefix() public function getBlockPrefix(): string
{ {
return 'tag'; return 'tag';
} }

View file

@ -38,7 +38,7 @@ class SiteCredentialType extends AbstractType
]); ]);
} }
public function getBlockPrefix() public function getBlockPrefix(): string
{ {
return 'site_credential'; return 'site_credential';
} }

View file

@ -22,7 +22,7 @@ class TaggingRuleImportType extends AbstractType
; ;
} }
public function getBlockPrefix() public function getBlockPrefix(): string
{ {
return 'upload_tagging_rule_file'; return 'upload_tagging_rule_file';
} }

View file

@ -40,7 +40,7 @@ class TaggingRuleType extends AbstractType
]); ]);
} }
public function getBlockPrefix() public function getBlockPrefix(): string
{ {
return 'tagging_rule'; return 'tagging_rule';
} }

View file

@ -27,7 +27,7 @@ class UploadImportType extends AbstractType
; ;
} }
public function getBlockPrefix() public function getBlockPrefix(): string
{ {
return 'upload_import_file'; return 'upload_import_file';
} }

View file

@ -30,7 +30,7 @@ class UserInformationType extends AbstractType
; ;
} }
public function getParent() public function getParent(): ?string
{ {
return RegistrationFormType::class; return RegistrationFormType::class;
} }
@ -42,7 +42,7 @@ class UserInformationType extends AbstractType
]); ]);
} }
public function getBlockPrefix() public function getBlockPrefix(): string
{ {
return 'update_user'; return 'update_user';
} }

View file

@ -234,7 +234,7 @@ class EntriesExport
$hash = sha1(\sprintf('%s:%s', $this->wallabagUrl, implode(',', $entryIds))); $hash = sha1(\sprintf('%s:%s', $this->wallabagUrl, implode(',', $entryIds)));
$book->setIdentifier(\sprintf('urn:wallabag:%s', $hash), EPub::IDENTIFIER_URI); $book->setIdentifier(\sprintf('urn:wallabag:%s', $hash), EPub::IDENTIFIER_URI);
return Response::create( return new Response(
$book->getBook(), $book->getBook(),
200, 200,
[ [
@ -309,7 +309,7 @@ class EntriesExport
// set image scale factor // set image scale factor
$pdf->setImageScale(PDF_IMAGE_SCALE_RATIO); $pdf->setImageScale(PDF_IMAGE_SCALE_RATIO);
return Response::create( return new Response(
$pdf->Output('', 'S'), $pdf->Output('', 'S'),
200, 200,
[ [
@ -354,7 +354,7 @@ class EntriesExport
$output = stream_get_contents($handle); $output = stream_get_contents($handle);
fclose($handle); fclose($handle);
return Response::create( return new Response(
$output, $output,
200, 200,
[ [
@ -370,7 +370,7 @@ class EntriesExport
*/ */
private function produceJson(): Response private function produceJson(): Response
{ {
return Response::create( return new Response(
$this->prepareSerializingContent('json'), $this->prepareSerializingContent('json'),
200, 200,
[ [
@ -386,7 +386,7 @@ class EntriesExport
*/ */
private function produceXml(): Response private function produceXml(): Response
{ {
return Response::create( return new Response(
$this->prepareSerializingContent('xml'), $this->prepareSerializingContent('xml'),
200, 200,
[ [
@ -410,7 +410,7 @@ class EntriesExport
$content .= $html->getText(); $content .= $html->getText();
} }
return Response::create( return new Response(
$content, $content,
200, 200,
[ [
@ -433,7 +433,7 @@ class EntriesExport
$content .= $converter->convert('<h1>' . $entry->getTitle() . '</h1>' . $entry->getContent()); $content .= $converter->convert('<h1>' . $entry->getTitle() . '</h1>' . $entry->getContent());
} }
return Response::create( return new Response(
$content, $content,
200, 200,
[ [

View file

@ -37,7 +37,7 @@ abstract class AbstractImport implements ImportInterface
$this->eventDispatcher = $eventDispatcher; $this->eventDispatcher = $eventDispatcher;
} }
public function setLogger(LoggerInterface $logger) public function setLogger(LoggerInterface $logger): void
{ {
$this->logger = $logger; $this->logger = $logger;
} }

View file

@ -16,6 +16,10 @@ class Matches
{ {
public function __invoke($subject, $pattern) public function __invoke($subject, $pattern)
{ {
if (null === $subject) {
return false;
}
return false !== stripos($subject, $pattern); return false !== stripos($subject, $pattern);
} }
} }

View file

@ -16,6 +16,10 @@ class NotMatches
{ {
public function __invoke($subject, $pattern) public function __invoke($subject, $pattern)
{ {
if (null === $subject) {
return true;
}
return false === stripos($subject, $pattern); return false === stripos($subject, $pattern);
} }
} }

View file

@ -33,7 +33,7 @@ class UsernameFeedTokenConverter implements ParamConverterInterface
* *
* Check, if object supported by our converter * Check, if object supported by our converter
*/ */
public function supports(ParamConverter $configuration) public function supports(ParamConverter $configuration): bool
{ {
// If there is no manager, this means that only Doctrine DBAL is configured // If there is no manager, this means that only Doctrine DBAL is configured
// In this case we can do nothing and just return // In this case we can do nothing and just return
@ -65,7 +65,7 @@ class UsernameFeedTokenConverter implements ParamConverterInterface
* @throws \InvalidArgumentException When route attributes are missing * @throws \InvalidArgumentException When route attributes are missing
* @throws NotFoundHttpException When object not found * @throws NotFoundHttpException When object not found
*/ */
public function apply(Request $request, ParamConverter $configuration) public function apply(Request $request, ParamConverter $configuration): bool
{ {
$username = $request->attributes->get('username'); $username = $request->attributes->get('username');
$feedToken = $request->attributes->get('token'); $feedToken = $request->attributes->get('token');

View file

@ -16,7 +16,7 @@ class ClientRepository extends ServiceEntityRepository
parent::__construct($registry, Client::class); parent::__construct($registry, Client::class);
} }
public function findOneBy(array $criteria, ?array $orderBy = null) public function findOneBy(array $criteria, ?array $orderBy = null): ?object
{ {
if (!empty($criteria['id'])) { if (!empty($criteria['id'])) {
// cast client id to be an integer to avoid postgres error: // cast client id to be an integer to avoid postgres error:

View file

@ -36,7 +36,7 @@ class WallabagExtension extends AbstractExtension implements GlobalsInterface
return []; return [];
} }
public function getFilters() public function getFilters(): array
{ {
return [ return [
new TwigFilter('removeWww', [$this, 'removeWww']), new TwigFilter('removeWww', [$this, 'removeWww']),
@ -45,7 +45,7 @@ class WallabagExtension extends AbstractExtension implements GlobalsInterface
]; ];
} }
public function getFunctions() public function getFunctions(): array
{ {
return [ return [
new TwigFunction('count_entries', [$this, 'countEntries']), new TwigFunction('count_entries', [$this, 'countEntries']),

View file

@ -48,7 +48,7 @@ class CreateConfigListenerTest extends TestCase
$this->dispatcher->addSubscriber($this->listener); $this->dispatcher->addSubscriber($this->listener);
$this->request = Request::create('/'); $this->request = Request::create('/');
$this->response = Response::create(); $this->response = new Response();
} }
public function testWithValidUser() public function testWithValidUser()

View file

@ -27,7 +27,7 @@ class UserLocaleListenerTest extends TestCase
$user->setConfig($config); $user->setConfig($config);
$userToken = new UsernamePasswordToken($user, '', 'test'); $userToken = new UsernamePasswordToken($user, 'test');
$request = Request::create('/'); $request = Request::create('/');
$event = new InteractiveLoginEvent($request, $userToken); $event = new InteractiveLoginEvent($request, $userToken);
@ -48,7 +48,7 @@ class UserLocaleListenerTest extends TestCase
$user->setConfig($config); $user->setConfig($config);
$userToken = new UsernamePasswordToken($user, '', 'test'); $userToken = new UsernamePasswordToken($user, 'test');
$request = Request::create('/'); $request = Request::create('/');
$event = new InteractiveLoginEvent($request, $userToken); $event = new InteractiveLoginEvent($request, $userToken);
@ -71,7 +71,7 @@ class UserLocaleListenerTest extends TestCase
$user->setConfig($config); $user->setConfig($config);
$userToken = new UsernamePasswordToken($user, '', 'test'); $userToken = new UsernamePasswordToken($user, 'test');
$request = Request::create('/'); $request = Request::create('/');
$event = new InteractiveLoginEvent($request, $userToken); $event = new InteractiveLoginEvent($request, $userToken);

View file

@ -53,7 +53,7 @@ class RedirectTest extends TestCase
$this->user->setConfig($config); $this->user->setConfig($config);
$this->token = new UsernamePasswordToken($this->user, 'password', 'key'); $this->token = new UsernamePasswordToken($this->user, 'key');
$tokenStorage = new TokenStorage(); $tokenStorage = new TokenStorage();
$tokenStorage->setToken($this->token); $tokenStorage->setToken($this->token);

View file

@ -55,7 +55,7 @@ class GrabySiteConfigBuilderTest extends WallabagTestCase
->method('getId') ->method('getId')
->willReturn(1); ->willReturn(1);
$token = new UsernamePasswordToken($user, 'pass', 'provider'); $token = new UsernamePasswordToken($user, 'provider');
$tokenStorage = new TokenStorage(); $tokenStorage = new TokenStorage();
$tokenStorage->setToken($token); $tokenStorage->setToken($token);
@ -114,7 +114,7 @@ class GrabySiteConfigBuilderTest extends WallabagTestCase
->method('getId') ->method('getId')
->willReturn(1); ->willReturn(1);
$token = new UsernamePasswordToken($user, 'pass', 'provider'); $token = new UsernamePasswordToken($user, 'provider');
$tokenStorage = new TokenStorage(); $tokenStorage = new TokenStorage();
$tokenStorage->setToken($token); $tokenStorage->setToken($token);
@ -173,7 +173,7 @@ class GrabySiteConfigBuilderTest extends WallabagTestCase
->method('getId') ->method('getId')
->willReturn(1); ->willReturn(1);
$token = new UsernamePasswordToken($user, 'pass', 'provider'); $token = new UsernamePasswordToken($user, 'provider');
$tokenStorage = new TokenStorage(); $tokenStorage = new TokenStorage();
$tokenStorage->setToken($token); $tokenStorage->setToken($token);
@ -291,7 +291,7 @@ class GrabySiteConfigBuilderTest extends WallabagTestCase
->method('getId') ->method('getId')
->willReturn(1); ->willReturn(1);
$token = new UsernamePasswordToken($user, 'pass', 'provider'); $token = new UsernamePasswordToken($user, 'provider');
$tokenStorage = new TokenStorage(); $tokenStorage = new TokenStorage();
$tokenStorage->setToken($token); $tokenStorage->setToken($token);