oss/wallabag
oss/wallabag
1
0
Fork 0
mirror of https://github.com/wallabag/wallabag.git synced 2025-08-01 17:38:38 +00:00
Code Wiki Activity

Cast client id to avoid PG error

Browse source 
If someone send a malformated client_id when trying to authenticate using the API we got a 500 if wallabag use postgres because the request send a string instead of an integer.
This commit is contained in:
Jeremy Benoist 2019-01-09 23:29:30 +01:00
parent 4d0c632c70
commit 3a2d4cf9fd
No known key found for this signature in database
GPG key ID: BCA73962457ACC3C
3 changed files with 34 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

14
tests/Wallabag/ApiBundle/Controller/DeveloperControllerTest.php
View file

@ -56,6 +56,20 @@ class DeveloperControllerTest extends WallabagCoreTestCase
$this->assertArrayHasKey('refresh_token', $data);
}
public function testCreateTokenWithBadClientId()
{
$client = $this->getClient();
$client->request('POST', '/oauth/v2/token', [
'grant_type' => 'password',
'client_id' => '$WALLABAG_CLIENT_ID',
'client_secret' => 'secret',
'username' => 'admin',
'password' => 'mypassword',
]);
$this->assertSame(400, $client->getResponse()->getStatusCode());
}
public function testListingClient()
{
$this->logInAs('admin');