Merge pull request #7289 from yguedidi/run-tests-in-no-debug-mode

Run tests in no debug mode

app/config/config.yml

@@ -125,6 +125,9 @@ fos_rest:
             # for an unknown reason, EACH REQUEST goes to FOS\RestBundle\EventListener\FormatListener
             # so we need to add custom rule for custom api export but also for all other routes of the application...
             - { path: '^/', priorities: ['text/html', '*/*'], fallback_format: html, prefer_extension: false }
+    exception:
+        messages:
+            Symfony\Component\HttpKernel\Exception\BadRequestHttpException: true
 
 nelmio_api_doc:
     areas:

app/config/services_test.yml

@@ -1,21 +1,4 @@
 services:
-    # see https://github.com/symfony/symfony/issues/24543
-    fos_user.user_manager.test:
-        alias: fos_user.user_manager
-        public: true
-
-    fos_user.security.login_manager.test:
-        alias: fos_user.security.login_manager
-        public: true
-
-    wallabag.entry_repository.test:
-        alias: Wallabag\Repository\EntryRepository
-        public: true
-
-    wallabag_user.user_repository.test:
-        alias: Wallabag\Repository\UserRepository
-        public: true
-
     filesystem_cache:
         class: Doctrine\Common\Cache\FilesystemCache
         arguments:

phpstan.neon

@@ -8,7 +8,7 @@ parameters:
         - tests
 
     symfony:
-        container_xml_path: %rootDir%/../../../var/cache/test/AppKernelTestDebugContainer.xml
+        container_xml_path: %rootDir%/../../../var/cache/dev/AppKernelDevDebugContainer.xml
 
     doctrine:
         objectManagerLoader: tests/object-manager.php

phpunit.xml.dist

@@ -16,6 +16,8 @@
     <php>
         <ini name="error_reporting" value="-1" />
         <server name="KERNEL_CLASS" value="AppKernel" />
+        <server name="APP_ENV" value="test" />
+        <server name="APP_DEBUG" value="0" />
         <env name="SYMFONY_DEPRECATIONS_HELPER" value="weak" />
     </php>
 

src/Controller/Api/EntryRestController.php

@@ -528,7 +528,7 @@ class EntryRestController extends WallabagRestController
         $limit = $this->getParameter('wallabag.api_limit_mass_actions');
 
         if (\count($urls) > $limit) {
-            throw new HttpException(400, 'API limit reached');
+            throw new BadRequestHttpException('API limit reached');
         }
 
         $results = [];

tests/Command/ReloadEntryCommandTest.php

@@ -6,6 +6,8 @@ use Symfony\Bundle\FrameworkBundle\Console\Application;
 use Symfony\Component\Console\Tester\CommandTester;
 use Tests\Wallabag\WallabagTestCase;
 use Wallabag\Entity\Entry;
+use Wallabag\Repository\EntryRepository;
+use Wallabag\Repository\UserRepository;
 
 class ReloadEntryCommandTest extends WallabagTestCase
 {
@@ -35,7 +37,7 @@ class ReloadEntryCommandTest extends WallabagTestCase
     {
         parent::setUp();
 
-        $userRepository = $this->getTestClient()->getContainer()->get('wallabag_user.user_repository.test');
+        $userRepository = static::getContainer()->get(UserRepository::class);
 
         $user = $userRepository->findOneByUserName('admin');
         $this->adminEntry = new Entry($user);
@@ -80,9 +82,8 @@ class ReloadEntryCommandTest extends WallabagTestCase
             'interactive' => false,
         ]);
 
-        $reloadedEntries = $this->getTestClient()
+        $reloadedEntries = static::getContainer()
-            ->getContainer()
+            ->get(EntryRepository::class)
-            ->get('wallabag.entry_repository.test')
             ->findById([$this->adminEntry->getId(), $this->bobEntry->getId()]);
 
         foreach ($reloadedEntries as $reloadedEntry) {
@@ -107,7 +108,7 @@ class ReloadEntryCommandTest extends WallabagTestCase
             'interactive' => false,
         ]);
 
-        $entryRepository = $this->getTestClient()->getContainer()->get('wallabag.entry_repository.test');
+        $entryRepository = static::getContainer()->get(EntryRepository::class);
 
         $reloadedAdminEntry = $entryRepository->find($this->adminEntry->getId());
         $this->assertNotEmpty($reloadedAdminEntry->getContent());
@@ -128,7 +129,7 @@ class ReloadEntryCommandTest extends WallabagTestCase
             '--only-not-parsed' => true,
         ]);
 
-        $entryRepository = $this->getTestClient()->getContainer()->get('wallabag.entry_repository.test');
+        $entryRepository = static::getContainer()->get(EntryRepository::class);
 
         $reloadedBobParsedEntry = $entryRepository->find($this->bobParsedEntry->getId());
         $this->assertEmpty($reloadedBobParsedEntry->getContent());

tests/Controller/Api/DeveloperControllerTest.php

@@ -132,7 +132,7 @@ class DeveloperControllerTest extends WallabagTestCase
     {
         $client = $this->getTestClient();
         $em = $client->getContainer()->get(EntityManagerInterface::class);
-        $userManager = $client->getContainer()->get('fos_user.user_manager.test');
+        $userManager = static::getContainer()->get('fos_user.user_manager');
         $user = $userManager->findUserBy(['username' => $username]);
         $apiClient = new Client($user);
         $apiClient->setName('My app');

tests/Controller/Api/WallabagApiTestCase.php

@@ -43,10 +43,10 @@ abstract class WallabagApiTestCase extends WebTestCase
     protected function createAuthorizedClient()
     {
         $client = $this->createUnauthorizedClient();
-        $container = $client->getContainer();
+        $container = static::getContainer();
 
         /** @var UserManager $userManager */
-        $userManager = $container->get('fos_user.user_manager.test');
+        $userManager = $container->get('fos_user.user_manager');
         $firewallName = $container->getParameter('fos_user.firewall_name');
 
         $this->user = $userManager->findUserBy(['username' => 'admin']);

tests/Controller/ConfigControllerTest.php

@@ -1313,7 +1313,8 @@ class ConfigControllerTest extends WallabagTestCase
         $client->submit($form, $data);
         $this->assertSame(302, $client->getResponse()->getStatusCode());
 
-        $user = $client->getContainer()->get('fos_user.user_manager.test')->findUserBy(['username' => 'admin']);
+        $user = static::getContainer()->get('fos_user.user_manager')->findUserBy(['username' => 'admin']);
+        \assert($user instanceof User);
         $taggingRules = $user->getConfig()->getTaggingRules()->toArray();
         $this->assertCount(5, $taggingRules);
         $this->assertSame('title matches "football"', $taggingRules[4]->getRule());

tests/Controller/ExportControllerTest.php

@@ -5,6 +5,7 @@ namespace Tests\Wallabag\Controller;
 use Doctrine\ORM\EntityManagerInterface;
 use Tests\Wallabag\WallabagTestCase;
 use Wallabag\Entity\Entry;
+use Wallabag\Repository\UserRepository;
 
 class ExportControllerTest extends WallabagTestCase
 {
@@ -328,11 +329,9 @@ class ExportControllerTest extends WallabagTestCase
 
     private function setUpForJsonExportFromSearch()
     {
-        $client = $this->getTestClient();
         $em = $this->getEntityManager();
 
-        $userRepository = $client->getContainer()
+        $userRepository = static::getContainer()->get(UserRepository::class);
-            ->get('wallabag_user.user_repository.test');
 
         $user = $userRepository->findOneByUserName('admin');
         $this->adminEntry = new Entry($user);

tests/WallabagTestCase.php

@@ -86,9 +86,9 @@ abstract class WallabagTestCase extends WebTestCase
      */
     public function logInAs($username)
     {
-        $container = $this->client->getContainer();
+        $container = static::getContainer();
 
-        $userManager = $container->get('fos_user.user_manager.test');
+        $userManager = $container->get('fos_user.user_manager');
         $firewallName = $container->getParameter('fos_user.firewall_name');
 
         $user = $userManager->findUserBy(['username' => $username]);

tests/bootstrap.php

@@ -14,6 +14,7 @@ if (!isPartialRun()) {
         'doctrine:database:drop',
         '--force',
         '--env=test',
+        '--no-debug',
     ]))->run(function ($type, $buffer) {
         echo $buffer;
     });
@@ -23,6 +24,7 @@ if (!isPartialRun()) {
         __DIR__ . '/../bin/console',
         'doctrine:database:create',
         '--env=test',
+        '--no-debug',
     ]))->mustRun(function ($type, $buffer) {
         echo $buffer;
     });
@@ -33,6 +35,7 @@ if (!isPartialRun()) {
         'doctrine:migrations:migrate',
         '--no-interaction',
         '--env=test',
+        '--no-debug',
         '-vv',
     ]))->mustRun(function ($type, $buffer) {
         echo $buffer;
@@ -45,6 +48,7 @@ if (!isPartialRun()) {
     'doctrine:fixtures:load',
     '--no-interaction',
     '--env=test',
+    '--no-debug',
 ]))->mustRun(function ($type, $buffer) {
     echo $buffer;
 });