mirror of
https://github.com/miniflux/v2.git
synced 2025-08-16 18:01:37 +00:00
93fc206f42
Don't use a slice of pointers to opml items, when we can simply use a slice of items instead. This should reduce the amount of memory allocations and the number of indirections the GC has to process, speedup up the import process. Note that this doesn't introduce any additional copies, as the only time a slice of subscription is created, the items are created and inserted inline.
47 lines
1.4 KiB
Go
47 lines
1.4 KiB
Go
// SPDX-FileCopyrightText: Copyright The Miniflux Authors. All rights reserved.
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
|
|
package opml // import "miniflux.app/v2/internal/reader/opml"
|
|
|
|
import (
|
|
"encoding/xml"
|
|
"fmt"
|
|
"io"
|
|
|
|
"miniflux.app/v2/internal/reader/encoding"
|
|
)
|
|
|
|
// parse reads an OPML file and returns a list of subscription.
|
|
func parse(data io.Reader) ([]subcription, error) {
|
|
opmlDocument := &opmlDocument{}
|
|
decoder := xml.NewDecoder(data)
|
|
decoder.Entity = xml.HTMLEntity
|
|
decoder.Strict = false
|
|
decoder.CharsetReader = encoding.CharsetReader
|
|
|
|
err := decoder.Decode(opmlDocument)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("opml: unable to parse document: %w", err)
|
|
}
|
|
|
|
return getSubscriptionsFromOutlines(opmlDocument.Outlines, ""), nil
|
|
}
|
|
|
|
func getSubscriptionsFromOutlines(outlines opmlOutlineCollection, category string) []subcription {
|
|
subscriptions := make([]subcription, 0, len(outlines))
|
|
|
|
for _, outline := range outlines {
|
|
if outline.IsSubscription() {
|
|
subscriptions = append(subscriptions, subcription{
|
|
Title: outline.GetTitle(),
|
|
FeedURL: outline.FeedURL,
|
|
SiteURL: outline.GetSiteURL(),
|
|
Description: outline.Description,
|
|
CategoryName: category,
|
|
})
|
|
} else if outline.Outlines.HasChildren() {
|
|
subscriptions = append(subscriptions, getSubscriptionsFromOutlines(outline.Outlines, outline.GetTitle())...)
|
|
}
|
|
}
|
|
return subscriptions
|
|
}
|