oss/miniflux-v2
oss/miniflux-v2
1
0
Fork 0
mirror of https://github.com/miniflux/v2.git synced 2025-09-15 18:57:04 +00:00
Code Wiki Activity

feat: remove the ref parameter from url

Browse source 
This is used by (at least) Ghost (https://forum.ghost.org/t/ref-parameter-being-added-to-links/38335)

Examples:
- https://blog.exploits.club/exploits-club-weekly-newsletter-66-mitigations-galore-dirtycow-revisited-program-analysis-for-uafs-and-more/
- https://labs.watchtowr.com/is-the-sofistication-in-the-room-with-us-x-forwarded-for-and-ivanti-connect-secure-cve-2025-22457/
This commit is contained in:
jvoisin 2025-04-04 16:49:52 +02:00 • committed by Frédéric Guillot
parent a5e3719773
commit ff2dfe977b
4 changed files with 68 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

40
internal/reader/urlcleaner/urlcleaner_test.go
View file

@ -14,6 +14,8 @@ func TestRemoveTrackingParams(t *testing.T) {
name string
input string
expected string
baseUrl string
feedUrl string
strictComparison bool
}{
{
@ -62,28 +64,64 @@ func TestRemoveTrackingParams(t *testing.T) {
input: "https://example.com/page?name=John%20Doe&utm_source=newsletter",
expected: "https://example.com/page?name=John+Doe",
},
{
name: "ref parameter for another url",
input: "https://example.com/page?ref=test.com",
baseUrl: "https://example.com/page",
expected: "https://example.com/page?ref=test.com",
},
{
name: "ref parameter for feed url",
input: "https://example.com/page?ref=feed.com",
baseUrl: "https://example.com/page",
expected: "https://example.com/page",
feedUrl: "http://feed.com",
},
{
name: "ref parameter for site url",
input: "https://example.com/page?ref=example.com",
baseUrl: "https://example.com/page",
expected: "https://example.com/page",
},
{
name: "ref parameter for base url",
input: "https://example.com/page?ref=example.com",
expected: "https://example.com/page",
baseUrl: "https://example.com",
feedUrl: "https://feedburned.com/example",
},
{
name: "ref parameter for base url on subdomain",
input: "https://blog.exploits.club/some-path?ref=blog.exploits.club",
expected: "https://blog.exploits.club/some-path",
baseUrl: "https://blog.exploits.club/some-path",
feedUrl: "https://feedburned.com/exploit.club",
},
{
name: "Non-standard URL parameter with no tracker",
input: "https://example.com/foo.jpg?crop/1420x708/format/webp",
expected: "https://example.com/foo.jpg?crop/1420x708/format/webp",
baseUrl: "https://example.com/page",
strictComparison: true,
},
{
name: "Invalid URL",
input: "https://example|org/",
baseUrl: "https://example.com/page",
expected: "",
},
{
name: "Non-HTTP URL",
input: "mailto:user@example.org",
expected: "mailto:user@example.org",
baseUrl: "https://example.com/page",
strictComparison: true,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
result, err := RemoveTrackingParameters(tt.input)
result, err := RemoveTrackingParameters(tt.baseUrl, tt.feedUrl, tt.input)
if tt.expected == "" {
if err == nil {
t.Errorf("Expected an error for invalid URL, but got none")