test(locale): increase test coverage to 100%

internal/locale/printer_test.go

@@ -5,7 +5,7 @@ package locale // import "miniflux.app/v2/internal/locale"
 
 import "testing"
 
-func TestTranslateWithMissingLanguage(t *testing.T) {
+func TestPrintfWithMissingLanguage(t *testing.T) {
 	defaultCatalog = catalog{}
 	translation := NewPrinter("invalid").Printf("missing.key")
 
@@ -14,7 +14,7 @@ func TestTranslateWithMissingLanguage(t *testing.T) {
 	}
 }
 
-func TestTranslateWithMissingKey(t *testing.T) {
+func TestPrintfWithMissingKey(t *testing.T) {
 	defaultCatalog = catalog{
 		"en_US": translationDict{
 			"k": "v",
@@ -27,7 +27,7 @@ func TestTranslateWithMissingKey(t *testing.T) {
 	}
 }
 
-func TestTranslateWithExistingKey(t *testing.T) {
+func TestPrintfWithExistingKey(t *testing.T) {
 	defaultCatalog = catalog{
 		"en_US": translationDict{
 			"auth.username": "Login",
@@ -40,7 +40,7 @@ func TestTranslateWithExistingKey(t *testing.T) {
 	}
 }
 
-func TestTranslateWithExistingKeyAndPlaceholder(t *testing.T) {
+func TestPrintfWithExistingKeyAndPlaceholder(t *testing.T) {
 	defaultCatalog = catalog{
 		"en_US": translationDict{
 			"key": "Test: %s",
@@ -56,7 +56,7 @@ func TestTranslateWithExistingKeyAndPlaceholder(t *testing.T) {
 	}
 }
 
-func TestTranslateWithMissingKeyAndPlaceholder(t *testing.T) {
+func TestPrintfWithMissingKeyAndPlaceholder(t *testing.T) {
 	defaultCatalog = catalog{
 		"en_US": translationDict{
 			"auth.username": "Login",
@@ -72,7 +72,7 @@ func TestTranslateWithMissingKeyAndPlaceholder(t *testing.T) {
 	}
 }
 
-func TestTranslateWithInvalidValue(t *testing.T) {
+func TestPrintfWithInvalidValue(t *testing.T) {
 	defaultCatalog = catalog{
 		"en_US": translationDict{
 			"auth.username": "Login",
@@ -88,7 +88,134 @@ func TestTranslateWithInvalidValue(t *testing.T) {
 	}
 }
 
-func TestTranslatePluralWithDefaultRule(t *testing.T) {
+func TestPrintWithMissingLanguage(t *testing.T) {
+	defaultCatalog = catalog{}
+	translation := NewPrinter("invalid").Print("missing.key")
+
+	if translation != "missing.key" {
+		t.Errorf(`Wrong translation, got %q`, translation)
+	}
+}
+
+func TestPrintWithMissingKey(t *testing.T) {
+	defaultCatalog = catalog{
+		"en_US": translationDict{
+			"existing.key": "value",
+		},
+	}
+
+	translation := NewPrinter("en_US").Print("missing.key")
+	if translation != "missing.key" {
+		t.Errorf(`Wrong translation, got %q`, translation)
+	}
+}
+
+func TestPrintWithExistingKey(t *testing.T) {
+	defaultCatalog = catalog{
+		"en_US": translationDict{
+			"auth.username": "Login",
+		},
+	}
+
+	translation := NewPrinter("en_US").Print("auth.username")
+	if translation != "Login" {
+		t.Errorf(`Wrong translation, got %q`, translation)
+	}
+}
+
+func TestPrintWithDifferentLanguages(t *testing.T) {
+	defaultCatalog = catalog{
+		"en_US": translationDict{
+			"greeting": "Hello",
+		},
+		"fr_FR": translationDict{
+			"greeting": "Bonjour",
+		},
+		"es_ES": translationDict{
+			"greeting": "Hola",
+		},
+	}
+
+	tests := []struct {
+		language string
+		expected string
+	}{
+		{"en_US", "Hello"},
+		{"fr_FR", "Bonjour"},
+		{"es_ES", "Hola"},
+	}
+
+	for _, test := range tests {
+		translation := NewPrinter(test.language).Print("greeting")
+		if translation != test.expected {
+			t.Errorf(`Wrong translation for %s, got %q instead of %q`, test.language, translation, test.expected)
+		}
+	}
+}
+
+func TestPrintWithInvalidTranslationType(t *testing.T) {
+	defaultCatalog = catalog{
+		"en_US": translationDict{
+			"valid.key":   "valid string",
+			"invalid.key": 12345, // not a string
+		},
+	}
+
+	printer := NewPrinter("en_US")
+
+	// Valid string should work
+	translation := printer.Print("valid.key")
+	if translation != "valid string" {
+		t.Errorf(`Wrong translation for valid key, got %q`, translation)
+	}
+
+	// Invalid type should return the key itself
+	translation = printer.Print("invalid.key")
+	if translation != "invalid.key" {
+		t.Errorf(`Wrong translation for invalid key, got %q`, translation)
+	}
+}
+
+func TestPrintWithNilTranslation(t *testing.T) {
+	defaultCatalog = catalog{
+		"en_US": translationDict{
+			"nil.key": nil,
+		},
+	}
+
+	translation := NewPrinter("en_US").Print("nil.key")
+	if translation != "nil.key" {
+		t.Errorf(`Wrong translation for nil value, got %q`, translation)
+	}
+}
+
+func TestPrintWithEmptyKey(t *testing.T) {
+	defaultCatalog = catalog{
+		"en_US": translationDict{
+			"": "empty key translation",
+		},
+	}
+
+	translation := NewPrinter("en_US").Print("")
+	if translation != "empty key translation" {
+		t.Errorf(`Wrong translation for empty key, got %q`, translation)
+	}
+}
+
+func TestPrintWithEmptyTranslation(t *testing.T) {
+	defaultCatalog = catalog{
+		"en_US": translationDict{
+			"empty.value": "",
+		},
+	}
+
+	translation := NewPrinter("en_US").Print("empty.value")
+	if translation != "" {
+		t.Errorf(`Wrong translation for empty value, got %q`, translation)
+	}
+}
+
+func TestPluralWithDefaultRule(t *testing.T) {
 	defaultCatalog = catalog{
 		"en_US": translationDict{
 			"number_of_users": []string{"%d user (%s)", "%d users (%s)"},
@@ -112,7 +239,7 @@ func TestTranslatePluralWithDefaultRule(t *testing.T) {
 	}
 }
 
-func TestTranslatePluralWithRussianRule(t *testing.T) {
+func TestPluralWithRussianRule(t *testing.T) {
 	defaultCatalog = catalog{
 		"en_US": translationDict{
 			"time_elapsed.years": []string{"%d year", "%d years"},
@@ -143,7 +270,7 @@ func TestTranslatePluralWithRussianRule(t *testing.T) {
 	}
 }
 
-func TestTranslatePluralWithMissingTranslation(t *testing.T) {
+func TestPluralWithMissingTranslation(t *testing.T) {
 	defaultCatalog = catalog{
 		"en_US": translationDict{
 			"number_of_users": []string{"%d user (%s)", "%d users (%s)"},
@@ -157,7 +284,7 @@ func TestTranslatePluralWithMissingTranslation(t *testing.T) {
 	}
 }
 
-func TestTranslatePluralWithInvalidValues(t *testing.T) {
+func TestPluralWithInvalidValues(t *testing.T) {
 	defaultCatalog = catalog{
 		"en_US": translationDict{
 			"number_of_users": []string{"%d user (%s)", "%d users (%s)"},
@@ -172,3 +299,126 @@ func TestTranslatePluralWithInvalidValues(t *testing.T) {
 		t.Errorf(`Wrong translation, got %q instead of %q`, translation, expected)
 	}
 }
+
+func TestPluralWithMissingLanguage(t *testing.T) {
+	defaultCatalog = catalog{}
+	translation := NewPrinter("invalid_language").Plural("test.key", 2)
+	expected := "test.key"
+	if translation != expected {
+		t.Errorf(`Wrong translation, got %q instead of %q`, translation, expected)
+	}
+}
+
+func TestPluralWithAnySliceType(t *testing.T) {
+	defaultCatalog = catalog{
+		"en_US": translationDict{
+			"test.key": []any{"%d item", "%d items"},
+		},
+	}
+
+	printer := NewPrinter("en_US")
+
+	translation := printer.Plural("test.key", 1, 1)
+	expected := "1 item"
+	if translation != expected {
+		t.Errorf(`Wrong translation for singular, got %q instead of %q`, translation, expected)
+	}
+
+	translation = printer.Plural("test.key", 2, 2)
+	expected = "2 items"
+	if translation != expected {
+		t.Errorf(`Wrong translation for plural, got %q instead of %q`, translation, expected)
+	}
+}
+
+func TestPluralWithMixedAnySliceTypes(t *testing.T) {
+	defaultCatalog = catalog{
+		"en_US": translationDict{
+			"mixed.key": []any{"single: %s", "multiple: %s", "many: %s"},
+		},
+	}
+
+	printer := NewPrinter("en_US")
+
+	// Test first element (should convert first any element to string)
+	translation := printer.Plural("mixed.key", 0, "test") // n=0 uses index 0
+	expected := "single: test"
+	if translation != expected {
+		t.Errorf(`Wrong translation for index 0, got %q instead of %q`, translation, expected)
+	}
+
+	// Test second element (should use plural form)
+	translation = printer.Plural("mixed.key", 2, "items") // plural form for default language
+	expected = "multiple: items"
+	if translation != expected {
+		t.Errorf(`Wrong translation for index 1, got %q instead of %q`, translation, expected)
+	}
+}
+
+func TestPluralWithIndexOutOfBounds(t *testing.T) {
+	defaultCatalog = catalog{
+		"test_lang": translationDict{
+			"limited.key": []string{"only one form"},
+		},
+	}
+
+	// Force a scenario where getPluralForm might return an index >= len(plurals)
+	// We'll create a scenario with Czech language rules
+	defaultCatalog["cs_CZ"] = translationDict{
+		"limited.key": []string{"one form only"}, // Only one form, but Czech has 3 plural forms
+	}
+
+	printer := NewPrinter("cs_CZ")
+	// n=5 should return index 2 for Czech, but we only have 1 form (index 0)
+	translation := printer.Plural("limited.key", 5)
+	expected := "limited.key"
+	if translation != expected {
+		t.Errorf(`Wrong translation for out of bounds index, got %q instead of %q`, translation, expected)
+	}
+}
+
+func TestPluralWithVariousLanguageRules(t *testing.T) {
+	defaultCatalog = catalog{
+		"ar_AR": translationDict{
+			"items": []string{"no items", "one item", "two items", "few items", "many items", "other items"},
+		},
+		"pl_PL": translationDict{
+			"files": []string{"one file", "few files", "many files"},
+		},
+		"ja_JP": translationDict{
+			"photos": []string{"photos"},
+		},
+	}
+
+	tests := []struct {
+		language string
+		key      string
+		n        int
+		expected string
+	}{
+		// Arabic tests
+		{"ar_AR", "items", 0, "no items"},
+		{"ar_AR", "items", 1, "one item"},
+		{"ar_AR", "items", 2, "two items"},
+		{"ar_AR", "items", 5, "few items"},   // n%100 >= 3 && n%100 <= 10
+		{"ar_AR", "items", 15, "many items"}, // n%100 >= 11
+
+		// Polish tests
+		{"pl_PL", "files", 1, "one file"},
+		{"pl_PL", "files", 3, "few files"},  // n%10 >= 2 && n%10 <= 4
+		{"pl_PL", "files", 5, "many files"}, // default case
+
+		// Japanese tests (always uses same form)
+		{"ja_JP", "photos", 1, "photos"},
+		{"ja_JP", "photos", 10, "photos"},
+	}
+
+	for _, test := range tests {
+		printer := NewPrinter(test.language)
+		translation := printer.Plural(test.key, test.n)
+		if translation != test.expected {
+			t.Errorf(`Wrong translation for %s with n=%d, got %q instead of %q`,
+				test.language, test.n, translation, test.expected)
+		}
+	}
+}