oss/miniflux-v2
oss/miniflux-v2
1
0
Fork 0
mirror of https://github.com/miniflux/v2.git synced 2025-06-27 16:36:00 +00:00
Code Wiki Activity

Golf a bit internal/ui/static/js/app.js

Browse source 
- Use `….classList.toggle` instead of `….classList.add`/`….classList.remove` in
  a condition
- Replace a `function()` with a `() =>`
- Use `Math.min` instead of a handwritten condition
This commit is contained in:
jvoisin 2025-01-04 23:13:55 +01:00
parent 79ec6ef81f
commit f67d2e230b
1 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
internal/ui/static/js/app.js
View file

@ -71,12 +71,11 @@ function toggleMainMenu(event) {
const menu = document.querySelector(".header nav ul"); const menu = document.querySelector(".header nav ul");
const menuToggleButton = document.querySelector(".logo"); const menuToggleButton = document.querySelector(".logo");
if (menu.classList.contains("js-menu-show")) { if (menu.classList.contains("js-menu-show")) {
menu.classList.remove("js-menu-show");
menuToggleButton.setAttribute("aria-expanded", false); menuToggleButton.setAttribute("aria-expanded", false);
} else { } else {
menu.classList.add("js-menu-show");
menuToggleButton.setAttribute("aria-expanded", true); menuToggleButton.setAttribute("aria-expanded", true);
} }
menu.classList.toggle("js-menu-show");
} }
// Handle click events for the main menu (<li> and <a>). // Handle click events for the main menu (<li> and <a>).
@ -662,7 +661,7 @@ function showToast(label, iconElement) {
const toastElementWrapper = document.getElementById("toast-wrapper"); const toastElementWrapper = document.getElementById("toast-wrapper");
if (toastElementWrapper) { if (toastElementWrapper) {
toastElementWrapper.classList.remove('toast-animate'); toastElementWrapper.classList.remove('toast-animate');
setTimeout(function () { setTimeout(() => {
toastElementWrapper.classList.add('toast-animate'); toastElementWrapper.classList.add('toast-animate');
}, 100); }, 100);
} }
@ -782,7 +781,7 @@ function handleMediaControl(button) {
enclosures.forEach((enclosure) => { enclosures.forEach((enclosure) => {
switch (action) { switch (action) {
case "seek": case "seek":
enclosure.currentTime = enclosure.currentTime + value > 0 ? enclosure.currentTime + value : 0; enclosure.currentTime = Math.min(enclosure.currentTime + value, 0);
break; break;
case "speed": case "speed":
// I set a floor speed of 0.25 to avoid too slow speed where it gives the impression it stopped. // I set a floor speed of 0.25 to avoid too slow speed where it gives the impression it stopped.