oss/miniflux-v2
oss/miniflux-v2
1
0
Fork 0
mirror of https://github.com/miniflux/v2.git synced 2025-08-06 17:41:00 +00:00
Code Wiki Activity

refactor(subscription): avoid using Sprintf to construct Youtube playlist feed URL

Browse source
This commit is contained in:
Frédéric Guillot 2025-07-07 17:03:36 -07:00
parent 2cfeefc8d2
commit e7b98afdbe
1 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
internal/reader/subscription/finder.go
View file

@ -5,7 +5,6 @@ package subscription // import "miniflux.app/v2/internal/reader/subscription"
import ( import (
"bytes" "bytes"
"fmt"
"io" "io"
"log/slog" "log/slog"
"net/url" "net/url"
@ -295,8 +294,8 @@ func (f *SubscriptionFinder) FindSubscriptionsFromYouTubeChannelPage(websiteURL
return nil, nil return nil, nil
} }
if _, after, found := strings.Cut(decodedUrl.Path, "channel/"); found { if _, channelID, found := strings.Cut(decodedUrl.Path, "channel/"); found {
feedURL := "https://www.youtube.com/feeds/videos.xml?channel_id=" + after feedURL := "https://www.youtube.com/feeds/videos.xml?channel_id=" + channelID
return Subscriptions{NewSubscription(websiteURL, feedURL, parser.FormatAtom)}, nil return Subscriptions{NewSubscription(websiteURL, feedURL, parser.FormatAtom)}, nil
} }
@ -316,7 +315,7 @@ func (f *SubscriptionFinder) FindSubscriptionsFromYouTubePlaylistPage(websiteURL
if (strings.HasPrefix(decodedUrl.Path, "/watch") && decodedUrl.Query().Has("list")) || strings.HasPrefix(decodedUrl.Path, "/playlist") { if (strings.HasPrefix(decodedUrl.Path, "/watch") && decodedUrl.Query().Has("list")) || strings.HasPrefix(decodedUrl.Path, "/playlist") {
playlistID := decodedUrl.Query().Get("list") playlistID := decodedUrl.Query().Get("list")
feedURL := fmt.Sprintf(`https://www.youtube.com/feeds/videos.xml?playlist_id=%s`, playlistID) feedURL := "https://www.youtube.com/feeds/videos.xml?playlist_id=" + playlistID
return Subscriptions{NewSubscription(websiteURL, feedURL, parser.FormatAtom)}, nil return Subscriptions{NewSubscription(websiteURL, feedURL, parser.FormatAtom)}, nil
} }