oss/miniflux-v2
oss/miniflux-v2
1
0
Fork 0
mirror of https://github.com/miniflux/v2.git synced 2025-07-22 17:18:37 +00:00
Code Wiki Activity

Update date parser to parse more invalid date formats

Browse source
This commit is contained in:
Frédéric Guillot 2023-11-01 19:26:16 +00:00
parent 500c60b807
commit e3eaaea15a
7 changed files with 15 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

6
internal/reader/date/parser.go
View file

@ -219,6 +219,10 @@ var dateFormats = []string{
"Mon, 2rd Jan 2006 15:04:05 MST",
"Mon, 2nd Jan 2006 15:04:05 MST",
"Mon, 2st Jan 2006 15:04:05 MST",
"Mon, Jan 02 2006 03:04:05 PM",
"Monday, January 2, 2006 - 15:04",
"01/02/06 15:04:05",
"02.01.06",
}
var invalidTimezoneReplacer = strings.NewReplacer(
@ -309,6 +313,7 @@ var invalidLocalizedDateReplacer = strings.NewReplacer(
// Parse parses a given date string using a large
// list of commonly found feed date formats.
func Parse(rawInput string) (t time.Time, err error) {
rawInput = strings.TrimSpace(rawInput)
timestamp, err := strconv.ParseInt(rawInput, 10, 64)
if err == nil {
return time.Unix(timestamp, 0), nil
@ -316,7 +321,6 @@ func Parse(rawInput string) (t time.Time, err error) {
processedInput := invalidLocalizedDateReplacer.Replace(rawInput)
processedInput = invalidTimezoneReplacer.Replace(processedInput)
processedInput = strings.TrimSpace(processedInput)
if processedInput == "" {
return t, errors.New(`date parser: empty value`)
}

6
internal/reader/date/parser_test.go
View file

@ -214,11 +214,15 @@ func TestParseWeirdDateFormat(t *testing.T) {
"Jun 23, 2023 19:00 GMT",
"09/15/2014 4:20 pm PST",
"Fri, 23rd Jun 2023 09:32:20 GMT",
"Sat, Oct 28 2023 08:28:28 PM",
"Monday, October 6, 2023 - 16:29\n",
"10/30/23 21:55:58",
"30.10.23",
}
for _, date := range dates {
if _, err := Parse(date); err != nil {
t.Errorf(`Unable to parse date: %q`, date)
t.Errorf(`Unable to parse date: %q (%v)`, date, err)
}
}
}