oss/miniflux-v2
oss/miniflux-v2
1
0
Fork 0
mirror of https://github.com/miniflux/v2.git synced 2025-08-01 17:38:37 +00:00
Code Wiki Activity

Minor concatenation-related simplifications in internal/storage/

Browse source 
Use plain strings concatenation instead of
building an array and then joining it.
This commit is contained in:
jvoisin 2024-03-18 17:35:20 +01:00 • committed by Frédéric Guillot
parent 863a5b3648
commit e2ee74428a
3 changed files with 14 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

8
internal/storage/batch.go
View file

@ -60,18 +60,16 @@ func (b *BatchBuilder) WithoutDisabledFeeds() *BatchBuilder {
}
func (b *BatchBuilder) FetchJobs() (jobs model.JobList, err error) {
var parts []string
parts = append(parts, `SELECT id, user_id FROM feeds`)
query := `SELECT id, user_id FROM feeds`
if len(b.conditions) > 0 {
parts = append(parts, fmt.Sprintf("WHERE %s", strings.Join(b.conditions, " AND ")))
query += fmt.Sprintf(" WHERE %s", strings.Join(b.conditions, " AND "))
}
if b.limit > 0 {
parts = append(parts, fmt.Sprintf("ORDER BY next_check_at ASC LIMIT %d", b.limit))
query += fmt.Sprintf(" ORDER BY next_check_at ASC LIMIT %d", b.limit)
}
query := strings.Join(parts, " ")
rows, err := b.db.Query(query, b.args...)
if err != nil {
return nil, fmt.Errorf(`store: unable to fetch batch of jobs: %v`, err)