oss/miniflux-v2
oss/miniflux-v2
1
0
Fork 0
mirror of https://github.com/miniflux/v2.git synced 2025-07-17 17:08:36 +00:00
Code Wiki Activity

Add support for protocol relative YouTube URLs

Browse source
This commit is contained in:
Frédéric Guillot 2018-07-04 22:45:44 -07:00
parent 6d0dc451e4
commit de1a4aad30
2 changed files with 12 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
reader/sanitizer/sanitizer.go
View file

@ -17,7 +17,7 @@ import (
) )
var ( var (
youtubeEmbedRegex = regexp.MustCompile(`http[s]?://www\.youtube\.com/embed/(.*)`) youtubeEmbedRegex = regexp.MustCompile(`//www\.youtube\.com/embed/(.*)`)
) )
// Sanitize returns safe HTML. // Sanitize returns safe HTML.
@ -291,6 +291,7 @@ func isBlacklistedResource(src string) bool {
func isValidIframeSource(src string) bool { func isValidIframeSource(src string) bool {
whitelist := []string{ whitelist := []string{
"//www.youtube.com",
"http://www.youtube.com", "http://www.youtube.com",
"https://www.youtube.com", "https://www.youtube.com",
"https://www.youtube-nocookie.com", "https://www.youtube-nocookie.com",

10
reader/sanitizer/sanitizer_test.go
View file

@ -203,6 +203,16 @@ func TestReplaceYoutubeURLAlreadyReplaced(t *testing.T) {
} }
} }
func TestReplaceProtocolRelativeYoutubeURL(t *testing.T) {
input := `<iframe src="//www.youtube.com/embed/Bf2W84jrGqs" width="560" height="314" allowfullscreen="allowfullscreen"></iframe>`
expected := `<iframe src="https://www.youtube-nocookie.com/embed/Bf2W84jrGqs" width="560" height="314" allowfullscreen="allowfullscreen" sandbox="allow-scripts allow-same-origin"></iframe>`
output := Sanitize("http://example.org/", input)
if expected != output {
t.Errorf(`Wrong output: "%s" != "%s"`, expected, output)
}
}
func TestReplaceIframeURL(t *testing.T) { func TestReplaceIframeURL(t *testing.T) {
input := `<iframe src="https://player.vimeo.com/video/123456?title=0&amp;byline=0"></iframe>` input := `<iframe src="https://player.vimeo.com/video/123456?title=0&amp;byline=0"></iframe>`
expected := `<iframe src="https://player.vimeo.com/video/123456?title=0&amp;byline=0" sandbox="allow-scripts allow-same-origin"></iframe>` expected := `<iframe src="https://player.vimeo.com/video/123456?title=0&amp;byline=0" sandbox="allow-scripts allow-same-origin"></iframe>`