oss/miniflux-v2
oss/miniflux-v2
1
0
Fork 0
mirror of https://github.com/miniflux/v2.git synced 2025-06-27 16:36:00 +00:00
Code Wiki Activity

fix(ui): avoid 500 error and NaN when marking as read a deleted entry

Browse source 
Steps to reproduce:

1. In /unread, open a feed's settings in a new tab. The feed must have unread entries in /unread.
2. In the new tab/window, delete the feed.
3. Without refreshing, mark an entry from the now-deleted feed as read.
4. Result: The total unread count in the UI header switches to NaN.
This commit is contained in:
Frédéric Guillot 2025-02-26 16:25:28 -08:00
parent 6ad2001c7d
commit d7c504f48e
1 changed files with 1 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

12
internal/storage/entry.go
View file

@ -369,20 +369,10 @@ func (s *Storage) ArchiveEntries(status string, days, limit int) (int64, error)
// SetEntriesStatus update the status of the given list of entries. // SetEntriesStatus update the status of the given list of entries.
func (s *Storage) SetEntriesStatus(userID int64, entryIDs []int64, status string) error { func (s *Storage) SetEntriesStatus(userID int64, entryIDs []int64, status string) error {
query := `UPDATE entries SET status=$1, changed_at=now() WHERE user_id=$2 AND id=ANY($3)` query := `UPDATE entries SET status=$1, changed_at=now() WHERE user_id=$2 AND id=ANY($3)`
result, err := s.db.Exec(query, status, userID, pq.Array(entryIDs)) if _, err := s.db.Exec(query, status, userID, pq.Array(entryIDs)); err != nil {
if err != nil {
return fmt.Errorf(`store: unable to update entries statuses %v: %v`, entryIDs, err) return fmt.Errorf(`store: unable to update entries statuses %v: %v`, entryIDs, err)
} }
count, err := result.RowsAffected()
if err != nil {
return fmt.Errorf(`store: unable to update these entries %v: %v`, entryIDs, err)
}
if count == 0 {
return errors.New(`store: nothing has been updated`)
}
return nil return nil
} }