oss/miniflux-v2
oss/miniflux-v2
1
0
Fork 0
mirror of https://github.com/miniflux/v2.git synced 2025-08-26 18:21:01 +00:00
Code Wiki Activity

refactor(http): use time.Duration for refresh interval

Browse source 
It's not clear which units of time used for refresh interval.
Convert to time.Duration for clarity.
This commit is contained in:
gudvinr 2025-08-18 23:10:18 +03:00 • committed by Frédéric Guillot
parent 30453ad7ec
commit c6536e8d90
6 changed files with 26 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

12
internal/config/config_test.go
View file

@ -784,12 +784,22 @@ func TestForceRefreshInterval(t *testing.T) {
t.Fatalf(`Parsing failure: %v`, err)
}
expected := 42
expected := 42 * time.Second
result := opts.ForceRefreshInterval()
if result != expected {
t.Fatalf(`Unexpected FORCE_REFRESH_INTERVAL value, got %v instead of %v`, result, expected)
}
sorted := opts.SortedOptions(false)
i := slices.IndexFunc(sorted, func(opt *option) bool {
return opt.Key == "FORCE_REFRESH_INTERVAL"
})
expectedSerialized := 42
if got := sorted[i].Value; got != expectedSerialized {
t.Fatalf(`Unexpected value in option output, got %q instead of %q`, got, expectedSerialized)
}
}
func TestDefaultBatchSizeValue(t *testing.T) {

8
internal/config/options.go
View file

@ -29,7 +29,7 @@ const (
defaultBasePath = ""
defaultWorkerPoolSize = 16
defaultPollingFrequency = 60
defaultForceRefreshInterval = 30
defaultForceRefreshInterval = 30 * time.Second
defaultBatchSize = 100
defaultPollingScheduler = "round_robin"
defaultSchedulerEntryFrequencyMinInterval = 5 * time.Minute
@ -130,7 +130,7 @@ type options struct {
cleanupArchiveUnreadDays int
cleanupArchiveBatchSize int
cleanupRemoveSessionsDays int
forceRefreshInterval int
forceRefreshInterval time.Duration
batchSize int
schedulerEntryFrequencyMinInterval time.Duration
schedulerEntryFrequencyMaxInterval time.Duration
@ -392,7 +392,7 @@ func (o *options) WorkerPoolSize() int {
}
// ForceRefreshInterval returns the force refresh interval
func (o *options) ForceRefreshInterval() int {
func (o *options) ForceRefreshInterval() time.Duration {
return o.forceRefreshInterval
}
@ -769,7 +769,7 @@ func (o *options) SortedOptions(redactSecret bool) []*option {
"OAUTH2_REDIRECT_URL": o.oauth2RedirectURL,
"OAUTH2_USER_CREATION": o.oauth2UserCreationAllowed,
"DISABLE_LOCAL_AUTH": o.disableLocalAuth,
"FORCE_REFRESH_INTERVAL": o.forceRefreshInterval,
"FORCE_REFRESH_INTERVAL": int(o.forceRefreshInterval.Seconds()),
"POLLING_FREQUENCY": o.pollingFrequency,
"POLLING_LIMIT_PER_HOST": o.pollingLimitPerHost,
"POLLING_PARSING_ERROR_LIMIT": o.pollingParsingErrorLimit,

2
internal/config/parser.go
View file

@ -139,7 +139,7 @@ func (p *parser) parseLines(lines []string) (err error) {
case "WORKER_POOL_SIZE":
p.opts.workerPoolSize = parseInt(value, defaultWorkerPoolSize)
case "FORCE_REFRESH_INTERVAL":
p.opts.forceRefreshInterval = parseInt(value, defaultForceRefreshInterval)
p.opts.forceRefreshInterval = parseInterval(value, time.Second, defaultForceRefreshInterval)
case "BATCH_SIZE":
p.opts.batchSize = parseInt(value, defaultBatchSize)
case "POLLING_FREQUENCY":