oss/miniflux-v2
oss/miniflux-v2
1
0
Fork 0
mirror of https://github.com/miniflux/v2.git synced 2025-06-27 16:36:00 +00:00
Code Wiki Activity

GitHub Actions: Add basic ESLinter checks

Browse source
This commit is contained in:
Frédéric Guillot 2024-03-10 20:52:56 -07:00
parent 45fa641d26
commit c51a3270da
3 changed files with 25 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

6
.github/workflows/linters.yml vendored
View file

@ -13,11 +13,13 @@ jobs:
runs-on: ubuntu-latest runs-on: ubuntu-latest
steps: steps:
- uses: actions/checkout@v4 - uses: actions/checkout@v4
- name: Install jshint - name: Install linters
run: | run: |
sudo npm install -g jshint@2.13.6 sudo npm install -g jshint@2.13.6 eslint@8.57.0
- name: Run jshint - name: Run jshint
run: jshint internal/ui/static/js/*.js run: jshint internal/ui/static/js/*.js
- name: Run ESLint
run: eslint internal/ui/static/js/*.js
golangci: golangci:
name: Golang Linter name: Golang Linter

9
internal/ui/static/js/.eslintrc.json Normal file
View file

@ -0,0 +1,9 @@
{
"env": {
"browser": true,
"es2017": true
},
"rules": {
"indent": ["error", 4]
}
}

24
internal/ui/static/js/app.js
View file

@ -40,9 +40,9 @@ function checkMenuToggleModeByLayout() {
logoElement.setAttribute("tabindex", "0"); logoElement.setAttribute("tabindex", "0");
logoElement.setAttribute("aria-label", logoToggleButtonLabel); logoElement.setAttribute("aria-label", logoToggleButtonLabel);
if (navMenuElementIsExpanded) { if (navMenuElementIsExpanded) {
logoElement.setAttribute("aria-expanded", "true"); logoElement.setAttribute("aria-expanded", "true");
} else { } else {
logoElement.setAttribute("aria-expanded", "false"); logoElement.setAttribute("aria-expanded", "false");
} }
homePageLinkElement.setAttribute("tabindex", "-1"); homePageLinkElement.setAttribute("tabindex", "-1");
} else { } else {
@ -175,12 +175,12 @@ function handleEntryStatus(item, element, setToRead) {
} }
if (isListView() && currentEntry.classList.contains('current-item')) { if (isListView() && currentEntry.classList.contains('current-item')) {
switch (item) { switch (item) {
case "previous": case "previous":
goToListItem(-1); goToListItem(-1);
break; break;
case "next": case "next":
goToListItem(1); goToListItem(1);
break; break;
} }
} }
} }
@ -246,7 +246,7 @@ function handleRefreshAllFeeds() {
function updateEntriesStatus(entryIDs, status, callback) { function updateEntriesStatus(entryIDs, status, callback) {
let url = document.body.dataset.entriesStatusUrl; let url = document.body.dataset.entriesStatusUrl;
let request = new RequestBuilder(url); let request = new RequestBuilder(url);
request.withBody({entry_ids: entryIDs, status: status}); request.withBody({ entry_ids: entryIDs, status: status });
request.withCallback((resp) => { request.withCallback((resp) => {
resp.json().then(count => { resp.json().then(count => {
if (callback) { if (callback) {
@ -358,8 +358,8 @@ function handleFetchOriginalContent() {
let request = new RequestBuilder(element.dataset.fetchContentUrl); let request = new RequestBuilder(element.dataset.fetchContentUrl);
request.withCallback((response) => { request.withCallback((response) => {
element.textContent = ''; element.textContent = '';
element.appendChild(previousElement); element.appendChild(previousElement);
response.json().then((data) => { response.json().then((data) => {
if (data.hasOwnProperty("content") && data.hasOwnProperty("reading_time")) { if (data.hasOwnProperty("content") && data.hasOwnProperty("reading_time")) {
@ -675,7 +675,7 @@ function handlePlayerProgressionSave(playerElement) {
) { ) {
playerElement.dataset.lastPosition = currentPositionInSeconds.toString(); playerElement.dataset.lastPosition = currentPositionInSeconds.toString();
let request = new RequestBuilder(playerElement.dataset.saveUrl); let request = new RequestBuilder(playerElement.dataset.saveUrl);
request.withBody({progression: currentPositionInSeconds}); request.withBody({ progression: currentPositionInSeconds });
request.execute(); request.execute();
} }
} }