mirror of
https://github.com/miniflux/v2.git
synced 2025-08-16 18:01:37 +00:00
Improve a bit internal/reader/scraper/scraper.go
- make findContentUsingCustomRules' more idiomatic, since in golang a function returning an error might return garbage in other parameter. Moreover, ignoring errors is bad practise. - getPredefinedScraperRules is now running in constant-time, instead of iterating on a list with around 50 items in it.
This commit is contained in:
parent
5b2558bf92
commit
c2d2f31438
2 changed files with 10 additions and 9 deletions
|
@ -19,6 +19,10 @@ func TestGetPredefinedRules(t *testing.T) {
|
|||
t.Error("Unable to find rule for linux.com")
|
||||
}
|
||||
|
||||
if getPredefinedScraperRules("https://linux.com/") == "" {
|
||||
t.Error("Unable to find rule for linux.com")
|
||||
}
|
||||
|
||||
if getPredefinedScraperRules("https://example.org/") != "" {
|
||||
t.Error("A rule not defined should not return anything")
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue