mirror of
https://github.com/miniflux/v2.git
synced 2025-08-31 18:31:01 +00:00
Replace a bunch of let
with const
According to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/const > Many style guides (including MDN's) recommend using const over let whenever a variable is not reassigned in its scope. This makes the intent clear that a variable's type (or value, in the case of a primitive) can never change.
This commit is contained in:
parent
fc4bdf3ab0
commit
beb8c80787
6 changed files with 41 additions and 44 deletions
|
@ -4,17 +4,17 @@ class DomHelper {
|
|||
}
|
||||
|
||||
static openNewTab(url) {
|
||||
let win = window.open("");
|
||||
const win = window.open("");
|
||||
win.opener = null;
|
||||
win.location = url;
|
||||
win.focus();
|
||||
}
|
||||
|
||||
static scrollPageTo(element, evenIfOnScreen) {
|
||||
let windowScrollPosition = window.pageYOffset;
|
||||
let windowHeight = document.documentElement.clientHeight;
|
||||
let viewportPosition = windowScrollPosition + windowHeight;
|
||||
let itemBottomPosition = element.offsetTop + element.offsetHeight;
|
||||
const windowScrollPosition = window.pageYOffset;
|
||||
const windowHeight = document.documentElement.clientHeight;
|
||||
const viewportPosition = windowScrollPosition + windowHeight;
|
||||
const itemBottomPosition = element.offsetTop + element.offsetHeight;
|
||||
|
||||
if (evenIfOnScreen || viewportPosition - itemBottomPosition < 0 || viewportPosition - element.offsetTop > windowHeight) {
|
||||
window.scrollTo(0, element.offsetTop - 10);
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue