oss/miniflux-v2
oss/miniflux-v2
1
0
Fork 0
mirror of https://github.com/miniflux/v2.git synced 2025-06-27 16:36:00 +00:00
Code Wiki Activity

Revert "perf(storage): take advantage of entries_feed_id_hash_key in updateEntry"

Browse source 
This reverts commit 6527c04307.
This commit is contained in:
jvoisin 2025-06-24 16:17:07 +02:00
parent 95eb6c1230
commit bbfe920fa5
1 changed files with 1 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
internal/storage/entry.go
View file

@ -168,7 +168,6 @@ func (s *Storage) createEntry(tx *sql.Tx, entry *model.Entry) error {
// Note: we do not update the published date because some feeds do not contains any date, // Note: we do not update the published date because some feeds do not contains any date,
// it default to time.Now() which could change the order of items on the history page. // it default to time.Now() which could change the order of items on the history page.
func (s *Storage) updateEntry(tx *sql.Tx, entry *model.Entry) error { func (s *Storage) updateEntry(tx *sql.Tx, entry *model.Entry) error {
// Note: This query uses entries_feed_id_hash_key index (filtering on user_id is not necessary).
query := ` query := `
UPDATE UPDATE
entries entries
@ -182,7 +181,7 @@ func (s *Storage) updateEntry(tx *sql.Tx, entry *model.Entry) error {
document_vectors = setweight(to_tsvector(left(coalesce($1, ''), 500000)), 'A') || setweight(to_tsvector(left(coalesce($4, ''), 500000)), 'B'), document_vectors = setweight(to_tsvector(left(coalesce($1, ''), 500000)), 'A') || setweight(to_tsvector(left(coalesce($4, ''), 500000)), 'B'),
tags=$10 tags=$10
WHERE WHERE
feed_id=$8 AND hash=$9 user_id=$7 AND feed_id=$8 AND hash=$9
RETURNING RETURNING
id id
` `
@ -228,7 +227,6 @@ func (s *Storage) entryExists(tx *sql.Tx, entry *model.Entry) (bool, error) {
func (s *Storage) IsNewEntry(feedID int64, entryHash string) bool { func (s *Storage) IsNewEntry(feedID int64, entryHash string) bool {
var result bool var result bool
// Note: This query uses entries_feed_id_hash_key index (filtering on user_id is not necessary).
s.db.QueryRow(`SELECT true FROM entries WHERE feed_id=$1 AND hash=$2`, feedID, entryHash).Scan(&result) s.db.QueryRow(`SELECT true FROM entries WHERE feed_id=$1 AND hash=$2`, feedID, entryHash).Scan(&result)
return !result return !result
} }