1
0
Fork 0
mirror of https://github.com/miniflux/v2.git synced 2025-09-15 18:57:04 +00:00

perf(storage): avoid heavy-weight SQL when marking feed as read

There is no need to perform a heavy-weight SQL query gathering all the
information available on a feed when we're only interested in its last check
timestamp.
This commit is contained in:
Julien Voisin 2025-08-06 03:01:58 +02:00 committed by GitHub
parent 826977bc8c
commit 924293ee5c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 14 additions and 8 deletions

View file

@ -9,6 +9,7 @@ import (
"fmt"
"log/slog"
"sort"
"time"
"miniflux.app/v2/internal/config"
"miniflux.app/v2/internal/model"
@ -40,6 +41,17 @@ func (s *Storage) FeedExists(userID, feedID int64) bool {
return result
}
// CheckedAt returns when the feed was last checked.
func (s *Storage) CheckedAt(userID, feedID int64) (time.Time, error) {
var result time.Time
query := `SELECT checked_at FROM feeds WHERE user_id=$1 AND id=$2 LIMIT 1`
err := s.db.QueryRow(query, userID, feedID).Scan(&result)
if err != nil {
return time.Now(), err
}
return result, nil
}
// CategoryFeedExists returns true if the given feed exists that belongs to the given category.
func (s *Storage) CategoryFeedExists(userID, categoryID, feedID int64) bool {
var result bool

View file

@ -15,19 +15,13 @@ func (h *handler) markFeedAsRead(w http.ResponseWriter, r *http.Request) {
feedID := request.RouteInt64Param(r, "feedID")
userID := request.UserID(r)
feed, err := h.store.FeedByID(userID, feedID)
checkedAt, err := h.store.CheckedAt(userID, feedID)
if err != nil {
html.ServerError(w, r, err)
return
}
if feed == nil {
html.NotFound(w, r)
return
}
if err = h.store.MarkFeedAsRead(userID, feedID, feed.CheckedAt); err != nil {
if err = h.store.MarkFeedAsRead(userID, feedID, checkedAt); err != nil {
html.ServerError(w, r, err)
return
}