mirror of
https://github.com/miniflux/v2.git
synced 2025-07-22 17:18:37 +00:00
refactor(readingtime): replace whatlanggo
with an ad-hoc implementation
The package `github.com/abadojack/whatlanggo` is unmaintained since 5 years, is overkill for simply detecting CJK, and is quite slow.
This commit is contained in:
parent
e22520fc55
commit
8df4b780a8
3 changed files with 22 additions and 21 deletions
1
go.mod
1
go.mod
|
@ -4,7 +4,6 @@ module miniflux.app/v2
|
||||||
|
|
||||||
require (
|
require (
|
||||||
github.com/PuerkitoBio/goquery v1.10.0
|
github.com/PuerkitoBio/goquery v1.10.0
|
||||||
github.com/abadojack/whatlanggo v1.0.1
|
|
||||||
github.com/andybalholm/brotli v1.1.1
|
github.com/andybalholm/brotli v1.1.1
|
||||||
github.com/coreos/go-oidc/v3 v3.11.0
|
github.com/coreos/go-oidc/v3 v3.11.0
|
||||||
github.com/go-webauthn/webauthn v0.11.2
|
github.com/go-webauthn/webauthn v0.11.2
|
||||||
|
|
2
go.sum
2
go.sum
|
@ -1,7 +1,5 @@
|
||||||
github.com/PuerkitoBio/goquery v1.10.0 h1:6fiXdLuUvYs2OJSvNRqlNPoBm6YABE226xrbavY5Wv4=
|
github.com/PuerkitoBio/goquery v1.10.0 h1:6fiXdLuUvYs2OJSvNRqlNPoBm6YABE226xrbavY5Wv4=
|
||||||
github.com/PuerkitoBio/goquery v1.10.0/go.mod h1:TjZZl68Q3eGHNBA8CWaxAN7rOU1EbDz3CWuolcO5Yu4=
|
github.com/PuerkitoBio/goquery v1.10.0/go.mod h1:TjZZl68Q3eGHNBA8CWaxAN7rOU1EbDz3CWuolcO5Yu4=
|
||||||
github.com/abadojack/whatlanggo v1.0.1 h1:19N6YogDnf71CTHm3Mp2qhYfkRdyvbgwWdd2EPxJRG4=
|
|
||||||
github.com/abadojack/whatlanggo v1.0.1/go.mod h1:66WiQbSbJBIlOZMsvbKe5m6pzQovxCH9B/K8tQB2uoc=
|
|
||||||
github.com/andybalholm/brotli v1.1.1 h1:PR2pgnyFznKEugtsUo0xLdDop5SKXd5Qf5ysW+7XdTA=
|
github.com/andybalholm/brotli v1.1.1 h1:PR2pgnyFznKEugtsUo0xLdDop5SKXd5Qf5ysW+7XdTA=
|
||||||
github.com/andybalholm/brotli v1.1.1/go.mod h1:05ib4cKhjx3OQYUY22hTVd34Bc8upXjOLL2rKwwZBoA=
|
github.com/andybalholm/brotli v1.1.1/go.mod h1:05ib4cKhjx3OQYUY22hTVd34Bc8upXjOLL2rKwwZBoA=
|
||||||
github.com/andybalholm/cascadia v1.3.2 h1:3Xi6Dw5lHF15JtdcmAHD3i1+T8plmv7BQ/nsViSLyss=
|
github.com/andybalholm/cascadia v1.3.2 h1:3Xi6Dw5lHF15JtdcmAHD3i1+T8plmv7BQ/nsViSLyss=
|
||||||
|
|
|
@ -7,33 +7,37 @@ package readingtime
|
||||||
import (
|
import (
|
||||||
"math"
|
"math"
|
||||||
"strings"
|
"strings"
|
||||||
|
"unicode"
|
||||||
"unicode/utf8"
|
"unicode/utf8"
|
||||||
|
|
||||||
"miniflux.app/v2/internal/reader/sanitizer"
|
"miniflux.app/v2/internal/reader/sanitizer"
|
||||||
|
|
||||||
"github.com/abadojack/whatlanggo"
|
|
||||||
)
|
)
|
||||||
|
|
||||||
// EstimateReadingTime returns the estimated reading time of an article in minute.
|
// EstimateReadingTime returns the estimated reading time of an article in minute.
|
||||||
func EstimateReadingTime(content string, defaultReadingSpeed, cjkReadingSpeed int) int {
|
func EstimateReadingTime(content string, defaultReadingSpeed, cjkReadingSpeed int) int {
|
||||||
sanitizedContent := sanitizer.StripTags(content)
|
sanitizedContent := sanitizer.StripTags(content)
|
||||||
|
truncationPoint := min(len(sanitizedContent), 50)
|
||||||
|
|
||||||
// Litterature on language detection says that around 100 signes is enough, we're safe here.
|
if isCJK(sanitizedContent[:truncationPoint]) {
|
||||||
truncationPoint := min(len(sanitizedContent), 250)
|
|
||||||
|
|
||||||
// We're only interested in identifying Japanse/Chinese/Korean
|
|
||||||
options := whatlanggo.Options{
|
|
||||||
Whitelist: map[whatlanggo.Lang]bool{
|
|
||||||
whatlanggo.Jpn: true,
|
|
||||||
whatlanggo.Cmn: true,
|
|
||||||
whatlanggo.Kor: true,
|
|
||||||
},
|
|
||||||
}
|
|
||||||
langInfo := whatlanggo.DetectWithOptions(sanitizedContent[:truncationPoint], options)
|
|
||||||
|
|
||||||
if langInfo.IsReliable() {
|
|
||||||
return int(math.Ceil(float64(utf8.RuneCountInString(sanitizedContent)) / float64(cjkReadingSpeed)))
|
return int(math.Ceil(float64(utf8.RuneCountInString(sanitizedContent)) / float64(cjkReadingSpeed)))
|
||||||
}
|
}
|
||||||
nbOfWords := len(strings.Fields(sanitizedContent))
|
return int(math.Ceil(float64(len(strings.Fields(sanitizedContent))) / float64(defaultReadingSpeed)))
|
||||||
return int(math.Ceil(float64(nbOfWords) / float64(defaultReadingSpeed)))
|
}
|
||||||
|
|
||||||
|
func isCJK(text string) bool {
|
||||||
|
totalCJK := 0
|
||||||
|
|
||||||
|
for _, r := range text[:min(len(text), 50)] {
|
||||||
|
if unicode.Is(unicode.Han, r) ||
|
||||||
|
unicode.Is(unicode.Hangul, r) ||
|
||||||
|
unicode.Is(unicode.Hiragana, r) ||
|
||||||
|
unicode.Is(unicode.Katakana, r) ||
|
||||||
|
unicode.Is(unicode.Yi, r) ||
|
||||||
|
unicode.Is(unicode.Bopomofo, r) {
|
||||||
|
totalCJK++
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// if at least 50% of the text is CJK, odds are that the text is in CJK.
|
||||||
|
return totalCJK > len(text)/50
|
||||||
}
|
}
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue