oss/miniflux-v2
oss/miniflux-v2
1
0
Fork 0
mirror of https://github.com/miniflux/v2.git synced 2025-08-01 17:38:37 +00:00
Code Wiki Activity

refactor(oauth2): no need to use io.WriteString when sha256 provides a way to obtain a sum in a single call

Browse source
This commit is contained in:
Julien Voisin 2024-12-26 18:39:55 +00:00 • committed by GitHub
parent bbfe39722a
commit 89620a7dd2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

8
internal/oauth2/authorization.go
View file

@ -6,7 +6,6 @@ package oauth2 // import "miniflux.app/v2/internal/oauth2"
import ( import (
"crypto/sha256" "crypto/sha256"
"encoding/base64" "encoding/base64"
"io"
"golang.org/x/oauth2" "golang.org/x/oauth2"
@ -33,17 +32,14 @@ func (u *Authorization) CodeVerifier() string {
func GenerateAuthorization(config *oauth2.Config) *Authorization { func GenerateAuthorization(config *oauth2.Config) *Authorization {
codeVerifier := crypto.GenerateRandomStringHex(32) codeVerifier := crypto.GenerateRandomStringHex(32)
sum := sha256.Sum256([]byte(codeVerifier))
sha2 := sha256.New()
io.WriteString(sha2, codeVerifier)
codeChallenge := base64.RawURLEncoding.EncodeToString(sha2.Sum(nil))
state := crypto.GenerateRandomStringHex(24) state := crypto.GenerateRandomStringHex(24)
authUrl := config.AuthCodeURL( authUrl := config.AuthCodeURL(
state, state,
oauth2.SetAuthURLParam("code_challenge_method", "S256"), oauth2.SetAuthURLParam("code_challenge_method", "S256"),
oauth2.SetAuthURLParam("code_challenge", codeChallenge), oauth2.SetAuthURLParam("code_challenge", base64.RawURLEncoding.EncodeToString(sum[:])),
) )
return &Authorization{ return &Authorization{