From 81df0b2a16e067cd7367ff6622b4fbfc7a9b1519 Mon Sep 17 00:00:00 2001 From: jvoisin Date: Tue, 17 Jun 2025 16:34:44 +0200 Subject: [PATCH] perf(rewrite): make getPredefinedRewriteRules O(1) --- internal/reader/rewrite/rewriter.go | 8 +++----- internal/reader/rewrite/rules.go | 2 +- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/internal/reader/rewrite/rewriter.go b/internal/reader/rewrite/rewriter.go index d22adf8e..4d806dad 100644 --- a/internal/reader/rewrite/rewriter.go +++ b/internal/reader/rewrite/rewriter.go @@ -136,11 +136,9 @@ func parseRules(rulesText string) (rules []rule) { } func getPredefinedRewriteRules(entryURL string) string { - urlDomain := urllib.Domain(entryURL) - for domain, rules := range predefinedRules { - if strings.Contains(urlDomain, domain) { - return rules - } + urlDomain := urllib.DomainWithoutWWW(entryURL) + if rules, ok := predefinedRules[urlDomain]; ok { + return rules } return "" diff --git a/internal/reader/rewrite/rules.go b/internal/reader/rewrite/rules.go index 86763f03..f4340710 100644 --- a/internal/reader/rewrite/rules.go +++ b/internal/reader/rewrite/rules.go @@ -26,11 +26,11 @@ var predefinedRules = map[string]string{ "optipess.com": "add_image_title", "peebleslab.com": "add_image_title", "quantamagazine.org": `add_youtube_video_from_id, remove("h6:not(.byline,.post__title__kicker), #comments, .next-post__content, .footer__section, figure .outer--content, script")`, + "qwantz.com": "add_image_title,add_mailto_subject", "sentfromthemoon.com": "add_image_title", "thedoghousediaries.com": "add_image_title", "theverge.com": `add_dynamic_image, remove("div.duet--recirculation--related-list, .hidden")`, "treelobsters.com": "add_image_title", - "www.qwantz.com": "add_image_title,add_mailto_subject", "xkcd.com": "add_image_title", "youtube.com": "add_youtube_video", }