oss/miniflux-v2
oss/miniflux-v2
1
0
Fork 0
mirror of https://github.com/miniflux/v2.git synced 2025-06-27 16:36:00 +00:00
Code Wiki Activity

feat(mediaproxy): pass original filename in Content-Disposition header

Browse source 
When you download/save proxified media, the original filename is lost. That
information could be retained by passing a header `Content-Disposition: inline;
filename="ORIGNAL_FILENAME.EXT"` when serving the media file. The requested URL
would still be obfuscated, but if the client downloads the file it'll use that
original filename.
This commit is contained in:
Frédéric Guillot 2024-10-30 20:11:11 -07:00
parent 39cc1887ea
commit 7c5d6cf35f
1 changed files with 10 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

14
internal/ui/proxy.go
View file

@ -12,6 +12,7 @@ import (
"log/slog" "log/slog"
"net/http" "net/http"
"net/url" "net/url"
"path"
"time" "time"
"miniflux.app/v2/internal/config" "miniflux.app/v2/internal/config"
@ -57,23 +58,23 @@ func (h *handler) mediaProxy(w http.ResponseWriter, r *http.Request) {
return return
} }
u, err := url.Parse(string(decodedURL)) parsedMediaURL, err := url.Parse(string(decodedURL))
if err != nil { if err != nil {
html.BadRequest(w, r, errors.New("invalid URL provided")) html.BadRequest(w, r, errors.New("invalid URL provided"))
return return
} }
if u.Scheme != "http" && u.Scheme != "https" { if parsedMediaURL.Scheme != "http" && parsedMediaURL.Scheme != "https" {
html.BadRequest(w, r, errors.New("invalid URL provided")) html.BadRequest(w, r, errors.New("invalid URL provided"))
return return
} }
if u.Host == "" { if parsedMediaURL.Host == "" {
html.BadRequest(w, r, errors.New("invalid URL provided")) html.BadRequest(w, r, errors.New("invalid URL provided"))
return return
} }
if !u.IsAbs() { if !parsedMediaURL.IsAbs() {
html.BadRequest(w, r, errors.New("invalid URL provided")) html.BadRequest(w, r, errors.New("invalid URL provided"))
return return
} }
@ -145,6 +146,11 @@ func (h *handler) mediaProxy(w http.ResponseWriter, r *http.Request) {
b.WithStatus(resp.StatusCode) b.WithStatus(resp.StatusCode)
b.WithHeader("Content-Security-Policy", `default-src 'self'`) b.WithHeader("Content-Security-Policy", `default-src 'self'`)
b.WithHeader("Content-Type", resp.Header.Get("Content-Type")) b.WithHeader("Content-Type", resp.Header.Get("Content-Type"))
if filename := path.Base(parsedMediaURL.Path); filename != "" {
b.WithHeader("Content-Disposition", fmt.Sprintf(`inline; filename="%s"`, filename))
}
forwardedResponseHeader := []string{"Content-Encoding", "Content-Type", "Content-Length", "Accept-Ranges", "Content-Range"} forwardedResponseHeader := []string{"Content-Encoding", "Content-Type", "Content-Length", "Accept-Ranges", "Content-Range"}
for _, responseHeaderName := range forwardedResponseHeader { for _, responseHeaderName := range forwardedResponseHeader {
if resp.Header.Get(responseHeaderName) != "" { if resp.Header.Get(responseHeaderName) != "" {