oss/miniflux-v2
oss/miniflux-v2
1
0
Fork 0
mirror of https://github.com/miniflux/v2.git synced 2025-06-27 16:36:00 +00:00
Code Wiki Activity

fix: remove progression save on shared entry

Browse source 
Shared entry does not link to any user and therefore should not display
any saved progression. Curiously, the progression of a user (the one that shared ?)
was still integrated in the page. This does not make sens regarding the sharing
feature itself. It is also a leak of user personal information onto a public page.

I simply removed the data from the template when the user object is not present.
I tested the change on "regular" entry page, ensuring the save progression feature
still works, and on shared page checking if any error happened in the JavaScript console.
Everything seems in order.
This commit is contained in:
Ztec 2024-09-03 14:07:47 +02:00 • committed by Frédéric Guillot
parent 2a4d2985c4
commit 74376cd33c
1 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

16
internal/template/templates/views/entry.html
View file

@ -171,12 +171,12 @@
{{ if hasPrefix .MimeType "audio/" }} {{ if hasPrefix .MimeType "audio/" }}
<div class="enclosure-audio" > <div class="enclosure-audio" >
<audio controls preload="metadata" <audio controls preload="metadata"
data-last-position="{{ .MediaProgression }}" {{ if $.user }}data-last-position="{{ .MediaProgression }}"{{ end }}
{{ if $.user.MediaPlaybackRate }}data-playback-rate="{{ $.user.MediaPlaybackRate }}"{{ end }} {{ if $.user.MediaPlaybackRate }}data-playback-rate="{{ $.user.MediaPlaybackRate }}"{{ end }}
{{ if $.user.MarkReadOnMediaPlayerCompletion }} {{ if $.user.MarkReadOnMediaPlayerCompletion }}
data-mark-read-on-completion="0.9" data-mark-read-on-completion="0.9"
{{ end }} {{ end }}
data-save-url="{{ route "saveEnclosureProgression" "enclosureID" .ID }}" {{ if $.user }}data-save-url="{{ route "saveEnclosureProgression" "enclosureID" .ID }}"{{ end }}
data-enclosure-id="{{.ID}}" data-enclosure-id="{{.ID}}"
> >
{{ if (and $.user (mustBeProxyfied "audio")) }} {{ if (and $.user (mustBeProxyfied "audio")) }}
@ -190,12 +190,12 @@
{{ else if hasPrefix .MimeType "video/" }} {{ else if hasPrefix .MimeType "video/" }}
<div class="enclosure-video"> <div class="enclosure-video">
<video controls preload="metadata" <video controls preload="metadata"
data-last-position="{{ .MediaProgression }}" {{ if $.user }}data-last-position="{{ .MediaProgression }}"{{ end }}
{{ if $.user.MediaPlaybackRate }}data-playback-rate="{{ $.user.MediaPlaybackRate }}"{{ end }} {{ if $.user.MediaPlaybackRate }}data-playback-rate="{{ $.user.MediaPlaybackRate }}"{{ end }}
{{ if $.user.MarkReadOnMediaPlayerCompletion }} {{ if $.user.MarkReadOnMediaPlayerCompletion }}
data-mark-read-on-completion="0.9" data-mark-read-on-completion="0.9"
{{ end }} {{ end }}
data-save-url="{{ route "saveEnclosureProgression" "enclosureID" .ID }}" {{ if $.user }}data-save-url="{{ route "saveEnclosureProgression" "enclosureID" .ID }}"{{ end }}
data-enclosure-id="{{.ID}}" data-enclosure-id="{{.ID}}"
> >
{{ if (and $.user (mustBeProxyfied "video")) }} {{ if (and $.user (mustBeProxyfied "video")) }}
@ -225,12 +225,12 @@
{{ if hasPrefix .MimeType "audio/" }} {{ if hasPrefix .MimeType "audio/" }}
<div class="enclosure-audio"> <div class="enclosure-audio">
<audio controls preload="metadata" <audio controls preload="metadata"
data-last-position="{{ .MediaProgression }}" {{ if $.user }}data-last-position="{{ .MediaProgression }}"{{ end }}
{{ if $.user.MediaPlaybackRate }}data-playback-rate="{{ $.user.MediaPlaybackRate }}"{{ end }} {{ if $.user.MediaPlaybackRate }}data-playback-rate="{{ $.user.MediaPlaybackRate }}"{{ end }}
{{ if $.user.MarkReadOnMediaPlayerCompletion }} {{ if $.user.MarkReadOnMediaPlayerCompletion }}
data-mark-read-on-completion="0.9" data-mark-read-on-completion="0.9"
{{ end }} {{ end }}
data-save-url="{{ route "saveEnclosureProgression" "enclosureID" .ID }}" {{ if $.user }}data-save-url="{{ route "saveEnclosureProgression" "enclosureID" .ID }}"{{ end }}
data-enclosure-id="{{.ID}}" data-enclosure-id="{{.ID}}"
> >
{{ if (and $.user (mustBeProxyfied "audio")) }} {{ if (and $.user (mustBeProxyfied "audio")) }}
@ -244,12 +244,12 @@
{{ else if hasPrefix .MimeType "video/" }} {{ else if hasPrefix .MimeType "video/" }}
<div class="enclosure-video"> <div class="enclosure-video">
<video controls preload="metadata" <video controls preload="metadata"
data-last-position="{{ .MediaProgression }}" {{ if $.user }}data-last-position="{{ .MediaProgression }}"{{ end }}
{{ if $.user.MediaPlaybackRate }}data-playback-rate="{{ $.user.MediaPlaybackRate }}"{{ end }} {{ if $.user.MediaPlaybackRate }}data-playback-rate="{{ $.user.MediaPlaybackRate }}"{{ end }}
{{ if $.user.MarkReadOnMediaPlayerCompletion }} {{ if $.user.MarkReadOnMediaPlayerCompletion }}
data-mark-read-on-completion="0.9" data-mark-read-on-completion="0.9"
{{ end }} {{ end }}
data-save-url="{{ route "saveEnclosureProgression" "enclosureID" .ID }}" {{ if $.user }}data-save-url="{{ route "saveEnclosureProgression" "enclosureID" .ID }}"{{ end }}
data-enclosure-id="{{.ID}}" data-enclosure-id="{{.ID}}"
> >
{{ if (and $.user (mustBeProxyfied "video")) }} {{ if (and $.user (mustBeProxyfied "video")) }}