oss/miniflux-v2
oss/miniflux-v2
1
0
Fork 0
mirror of https://github.com/miniflux/v2.git synced 2025-09-15 18:57:04 +00:00
Code Wiki Activity

refactor(misc): fix a handful of TODO

Browse source
This commit is contained in:
jvoisin 2025-08-08 22:14:22 +02:00 • committed by Frédéric Guillot
parent 06cbf1b3b3
commit 485baf9654
9 changed files with 18 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

5
internal/reader/atom/atom_03_adapter.go
View file

@ -18,11 +18,6 @@ type atom03Adapter struct {
atomFeed *atom03Feed
}
// TODO No need for a constructor, as it's only used in this package
func NewAtom03Adapter(atomFeed *atom03Feed) *atom03Adapter {
return &atom03Adapter{atomFeed}
}
func (a *atom03Adapter) buildFeed(baseURL string) *model.Feed {
feed := new(model.Feed)

10
internal/reader/atom/atom_10_adapter.go
View file

@ -18,15 +18,15 @@ import (
"miniflux.app/v2/internal/urllib"
)
type Atom10Adapter struct {
type atom10Adapter struct {
atomFeed *atom10Feed
}
func NewAtom10Adapter(atomFeed *atom10Feed) *Atom10Adapter {
return &Atom10Adapter{atomFeed}
func NewAtom10Adapter(atomFeed *atom10Feed) *atom10Adapter {
return &atom10Adapter{atomFeed}
}
func (a *Atom10Adapter) BuildFeed(baseURL string) *model.Feed {
func (a *atom10Adapter) BuildFeed(baseURL string) *model.Feed {
feed := new(model.Feed)
// Populate the feed URL.
@ -72,7 +72,7 @@ func (a *Atom10Adapter) BuildFeed(baseURL string) *model.Feed {
return feed
}
func (a *Atom10Adapter) populateEntries(siteURL string) model.Entries {
func (a *atom10Adapter) populateEntries(siteURL string) model.Entries {
entries := make(model.Entries, 0, len(a.atomFeed.Entries))
for _, atomEntry := range a.atomFeed.Entries {

6
internal/reader/atom/parser.go
View file

@ -19,12 +19,14 @@ func Parse(baseURL string, r io.ReadSeeker, version string) (*model.Feed, error)
if err := xml_decoder.NewXMLDecoder(r).Decode(atomFeed); err != nil {
return nil, fmt.Errorf("atom: unable to parse Atom 0.3 feed: %w", err)
}
return NewAtom03Adapter(atomFeed).buildFeed(baseURL), nil
adapter := &atom03Adapter{atomFeed}
return adapter.buildFeed(baseURL), nil
default:
atomFeed := new(atom10Feed)
if err := xml_decoder.NewXMLDecoder(r).Decode(atomFeed); err != nil {
return nil, fmt.Errorf("atom: unable to parse Atom 1.0 feed: %w", err)
}
return NewAtom10Adapter(atomFeed).BuildFeed(baseURL), nil
adapter := &atom10Adapter{atomFeed}
return adapter.BuildFeed(baseURL), nil
}
}