oss/miniflux-v2
oss/miniflux-v2
1
0
Fork 0
mirror of https://github.com/miniflux/v2.git synced 2025-06-27 16:36:00 +00:00
Code Wiki Activity

refactor(processor): simplify bilibili processing

Browse source 
- Use strings.Contains instead of a regex
- Use strings concatenation instead of a call to fmt.Sprintf
- Use `any` instead of `interface{}`
This commit is contained in:
jvoisin 2025-06-18 22:22:11 +02:00 • committed by Frédéric Guillot
parent 86c58e11f6
commit 46b159ac58
1 changed files with 5 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

12
internal/reader/processor/bilibili.go
View file

@ -8,6 +8,7 @@ import (
"fmt"
"log/slog"
"regexp"
"strings"
"miniflux.app/v2/internal/config"
"miniflux.app/v2/internal/model"
@ -16,7 +17,6 @@ import (
)
var (
bilibiliURLRegex = regexp.MustCompile(`bilibili\.com/video/(.*)$`)
bilibiliVideoIdRegex = regexp.MustCompile(`/video/(?:av(\d+)|BV([a-zA-Z0-9]+))`)
)
@ -24,9 +24,7 @@ func shouldFetchBilibiliWatchTime(entry *model.Entry) bool {
if !config.Opts.FetchBilibiliWatchTime() {
return false
}
matches := bilibiliURLRegex.FindStringSubmatch(entry.URL)
urlMatchesBilibiliPattern := len(matches) == 2
return urlMatchesBilibiliPattern
return strings.Contains(entry.URL, "bilibili.com/video/")
}
func extractBilibiliVideoID(websiteURL string) (string, string, error) {
@ -52,7 +50,7 @@ func fetchBilibiliWatchTime(websiteURL string) (int, error) {
if extractErr != nil {
return 0, extractErr
}
bilibiliApiURL := fmt.Sprintf("https://api.bilibili.com/x/web-interface/view?%s=%s", idType, videoID)
bilibiliApiURL := "https://api.bilibili.com/x/web-interface/view?" + idType + "=" + videoID
responseHandler := fetcher.NewResponseHandler(requestBuilder.ExecuteRequest(bilibiliApiURL))
defer responseHandler.Close()
@ -65,7 +63,7 @@ func fetchBilibiliWatchTime(websiteURL string) (int, error) {
return 0, localizedError.Error()
}
var result map[string]interface{}
var result map[string]any
doc := json.NewDecoder(responseHandler.Body(config.Opts.HTTPClientMaxBodySize()))
if docErr := doc.Decode(&result); docErr != nil {
return 0, fmt.Errorf("failed to decode API response: %v", docErr)
@ -75,7 +73,7 @@ func fetchBilibiliWatchTime(websiteURL string) (int, error) {
return 0, fmt.Errorf("API returned error code: %v", result["code"])
}
data, ok := result["data"].(map[string]interface{})
data, ok := result["data"].(map[string]any)
if !ok {
return 0, fmt.Errorf("data field not found or not an object")
}