oss/miniflux-v2
oss/miniflux-v2
1
0
Fork 0
mirror of https://github.com/miniflux/v2.git synced 2025-08-16 18:01:37 +00:00
Code Wiki Activity

perf(misc): use arrays instead of slices where possible

Browse source 
Arrays have a fixed size in go, while slices don't, making the former way
faster than the latter: https://go-benchmarks.com/array-vs-slice
This commit is contained in:
jvoisin 2025-08-11 16:28:08 +02:00 • committed by Frédéric Guillot
parent 68984da332
commit 3a01f8a691
5 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
internal/http/request/client_ip.go
View file

@ -11,7 +11,7 @@ import (
// FindClientIP returns the client real IP address based on trusted Reverse-Proxy HTTP headers. // FindClientIP returns the client real IP address based on trusted Reverse-Proxy HTTP headers.
func FindClientIP(r *http.Request) string { func FindClientIP(r *http.Request) string {
headers := []string{"X-Forwarded-For", "X-Real-Ip"} headers := [...]string{"X-Forwarded-For", "X-Real-Ip"}
for _, header := range headers { for _, header := range headers {
value := r.Header.Get(header) value := r.Header.Get(header)

2
internal/reader/icon/finder.go
View file

@ -251,7 +251,7 @@ func findIconURLsFromHTMLDocument(body io.Reader, contentType string) ([]string,
return nil, fmt.Errorf("icon: unable to read document: %v", err) return nil, fmt.Errorf("icon: unable to read document: %v", err)
} }
queries := []string{ queries := [...]string{
"link[rel='icon' i][href]", "link[rel='icon' i][href]",
"link[rel='shortcut icon' i][href]", "link[rel='shortcut icon' i][href]",
"link[rel='icon shortcut' i][href]", "link[rel='icon shortcut' i][href]",

2
internal/reader/processor/reading_time.go
View file

@ -65,7 +65,7 @@ func updateEntryReadingTime(store *storage.Storage, feed *model.Feed, entry *mod
} }
// Define watch time fetching scenarios // Define watch time fetching scenarios
watchTimeScenarios := []struct { watchTimeScenarios := [...]struct {
shouldFetch func(*model.Entry) bool shouldFetch func(*model.Entry) bool
fetchFunc func(string) (int, error) fetchFunc func(string) (int, error)
platform string platform string

4
internal/reader/rewrite/content_rewrite_functions.go
View file

@ -107,7 +107,7 @@ func addDynamicImage(entryContent string) string {
doc := goquery.NewDocumentFromNode(parserHtml) doc := goquery.NewDocumentFromNode(parserHtml)
// Ordered most preferred to least preferred. // Ordered most preferred to least preferred.
candidateAttrs := []string{ candidateAttrs := [...]string{
"data-src", "data-src",
"data-original", "data-original",
"data-orig", "data-orig",
@ -124,7 +124,7 @@ func addDynamicImage(entryContent string) string {
"data-380src", "data-380src",
} }
candidateSrcsetAttrs := []string{ candidateSrcsetAttrs := [...]string{
"data-srcset", "data-srcset",
} }

4
internal/ui/proxy.go
View file

@ -96,7 +96,7 @@ func (h *handler) mediaProxy(w http.ResponseWriter, r *http.Request) {
req.Header.Set("Referer", referer) req.Header.Set("Referer", referer)
} }
forwardedRequestHeader := []string{"Range", "Accept", "Accept-Encoding", "User-Agent"} forwardedRequestHeader := [...]string{"Range", "Accept", "Accept-Encoding", "User-Agent"}
for _, requestHeaderName := range forwardedRequestHeader { for _, requestHeaderName := range forwardedRequestHeader {
if r.Header.Get(requestHeaderName) != "" { if r.Header.Get(requestHeaderName) != "" {
req.Header.Set(requestHeaderName, r.Header.Get(requestHeaderName)) req.Header.Set(requestHeaderName, r.Header.Get(requestHeaderName))
@ -151,7 +151,7 @@ func (h *handler) mediaProxy(w http.ResponseWriter, r *http.Request) {
b.WithHeader("Content-Disposition", fmt.Sprintf(`inline; filename="%s"`, filename)) b.WithHeader("Content-Disposition", fmt.Sprintf(`inline; filename="%s"`, filename))
} }
forwardedResponseHeader := []string{"Content-Encoding", "Content-Type", "Content-Length", "Accept-Ranges", "Content-Range"} forwardedResponseHeader := [...]string{"Content-Encoding", "Content-Type", "Content-Length", "Accept-Ranges", "Content-Range"}
for _, responseHeaderName := range forwardedResponseHeader { for _, responseHeaderName := range forwardedResponseHeader {
if resp.Header.Get(responseHeaderName) != "" { if resp.Header.Get(responseHeaderName) != "" {
b.WithHeader(responseHeaderName, resp.Header.Get(responseHeaderName)) b.WithHeader(responseHeaderName, resp.Header.Get(responseHeaderName))