oss/miniflux-v2
oss/miniflux-v2
1
0
Fork 0
mirror of https://github.com/miniflux/v2.git synced 2025-08-11 17:51:01 +00:00
Code Wiki Activity

refactor(js): combine handleBookmark and toggleBookmark functions

Browse source
This commit is contained in:
Frédéric Guillot 2025-08-02 17:56:23 -07:00
parent d2cfca589b
commit 391792a424
1 changed files with 10 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

32
internal/ui/static/js/app.js
View file

@ -619,23 +619,11 @@ function handleSaveEntryAction(element = null) {
* *
* @param {Element} element - The element that triggered the bookmark action. * @param {Element} element - The element that triggered the bookmark action.
*/ */
function handleBookmark(element) { function handleBookmarkAction(element) {
const toasting = !element;
const currentEntry = findEntry(element); const currentEntry = findEntry(element);
if (currentEntry) { if (!currentEntry) return;
toggleBookmark(currentEntry, toasting);
}
}
/** const buttonElement = currentEntry.querySelector(":is(a, button)[data-toggle-bookmark]");
* Toggle the bookmark status of an entry.
*
* @param {Element} parentElement - The parent element containing the bookmark button.
* @param {boolean} toasting - Whether to show a toast notification.
* @returns {void}
*/
function toggleBookmark(parentElement, toasting) {
const buttonElement = parentElement.querySelector(":is(a, button)[data-toggle-bookmark]");
if (!buttonElement) return; if (!buttonElement) return;
insertIconLabelElement(buttonElement, buttonElement.dataset.labelLoading); insertIconLabelElement(buttonElement, buttonElement.dataset.labelLoading);
@ -648,14 +636,14 @@ function toggleBookmark(parentElement, toasting) {
const iconElement = document.querySelector(isStarred ? "template#icon-star" : "template#icon-unstar"); const iconElement = document.querySelector(isStarred ? "template#icon-star" : "template#icon-unstar");
const label = isStarred ? buttonElement.dataset.labelStar : buttonElement.dataset.labelUnstar; const label = isStarred ? buttonElement.dataset.labelStar : buttonElement.dataset.labelUnstar;
if (toasting) { buttonElement.replaceChildren(iconElement.content.cloneNode(true));
insertIconLabelElement(buttonElement, label, false);
buttonElement.dataset.value = newStarStatus;
if (!element) {
const toastKey = isStarred ? "toastUnstar" : "toastStar"; const toastKey = isStarred ? "toastUnstar" : "toastStar";
showToast(buttonElement.dataset[toastKey], iconElement); showToast(buttonElement.dataset[toastKey], iconElement);
} }
buttonElement.replaceChildren(iconElement.content.cloneNode(true));
insertIconLabelElement(buttonElement, label);
buttonElement.dataset.value = newStarStatus;
}); });
} }
@ -1146,7 +1134,7 @@ function initializeKeyboardShortcuts() {
keyboardHandler.on("A", markPageAsRead); keyboardHandler.on("A", markPageAsRead);
keyboardHandler.on("s", () => handleSaveEntryAction()); keyboardHandler.on("s", () => handleSaveEntryAction());
keyboardHandler.on("d", handleFetchOriginalContent); keyboardHandler.on("d", handleFetchOriginalContent);
keyboardHandler.on("f", () => handleBookmark()); keyboardHandler.on("f", () => handleBookmarkAction());
// Feed actions // Feed actions
keyboardHandler.on("F", goToFeedPage); keyboardHandler.on("F", goToFeedPage);
@ -1181,7 +1169,7 @@ function initializeTouchHandler() {
function initializeClickHandlers() { function initializeClickHandlers() {
// Entry actions // Entry actions
onClick(":is(a, button)[data-save-entry]", (event) => handleSaveEntryAction(event.target)); onClick(":is(a, button)[data-save-entry]", (event) => handleSaveEntryAction(event.target));
onClick(":is(a, button)[data-toggle-bookmark]", (event) => handleBookmark(event.target)); onClick(":is(a, button)[data-toggle-bookmark]", (event) => handleBookmarkAction(event.target));
onClick(":is(a, button)[data-toggle-status]", (event) => handleEntryStatus("next", event.target)); onClick(":is(a, button)[data-toggle-status]", (event) => handleEntryStatus("next", event.target));
onClick(":is(a, button)[data-fetch-content-entry]", handleFetchOriginalContent); onClick(":is(a, button)[data-fetch-content-entry]", handleFetchOriginalContent);
onClick(":is(a, button)[data-share-status]", handleEntryShareAction); onClick(":is(a, button)[data-share-status]", handleEntryShareAction);