diff --git a/internal/api/api_integration_test.go b/internal/api/api_integration_test.go index 890a19ab..c7fa684f 100644 --- a/internal/api/api_integration_test.go +++ b/internal/api/api_integration_test.go @@ -2932,3 +2932,32 @@ func TestFlushHistoryEndpoint(t *testing.T) { t.Fatalf(`Invalid total, got %d`, readEntries.Total) } } +func TestRemoveFeedAsRegularUser(t *testing.T) { + testConfig := newIntegrationTestConfig() + if !testConfig.isConfigured() { + t.Skip(skipIntegrationTestsMessage) + } + + adminClient := miniflux.NewClient(testConfig.testBaseURL, testConfig.testAdminUsername, testConfig.testAdminPassword) + regularTestUser, err := adminClient.CreateUser(testConfig.genRandomUsername(), testConfig.testRegularPassword, false) + if err != nil { + t.Fatal(err) + } + defer adminClient.DeleteUser(regularTestUser.ID) + + regularUserClient := miniflux.NewClient(testConfig.testBaseURL, regularTestUser.Username, testConfig.testRegularPassword) + feedID, err := regularUserClient.CreateFeed(&miniflux.FeedCreationRequest{ + FeedURL: testConfig.testFeedURL, + }) + if err != nil { + t.Fatal(err) + } + + if err := regularUserClient.DeleteFeed(feedID); err != nil { + t.Fatal(err) + } + + if _, err := regularUserClient.Feed(feedID); err == nil { + t.Errorf(`Got a feed (%d) even though it was deleted, was expecting an error instead.`, feedID) + } +} diff --git a/internal/storage/feed.go b/internal/storage/feed.go index 3efdaf5e..54c293a7 100644 --- a/internal/storage/feed.go +++ b/internal/storage/feed.go @@ -7,7 +7,6 @@ import ( "database/sql" "errors" "fmt" - "log/slog" "sort" "time" @@ -470,29 +469,9 @@ func (s *Storage) UpdateFeedError(feed *model.Feed) (err error) { // RemoveFeed removes a feed and all entries. // This operation can takes time if the feed has lot of entries. func (s *Storage) RemoveFeed(userID, feedID int64) error { - rows, err := s.db.Query(`SELECT id FROM entries WHERE user_id=$1 AND feed_id=$2`, userID, feedID) - if err != nil { - return fmt.Errorf(`store: unable to get user feed entries: %v`, err) - } - defer rows.Close() - - for rows.Next() { - var entryID int64 - if err := rows.Scan(&entryID); err != nil { - return fmt.Errorf(`store: unable to read user feed entry ID: %v`, err) - } - - slog.Debug("Deleting entry", - slog.Int64("user_id", userID), - slog.Int64("feed_id", feedID), - slog.Int64("entry_id", entryID), - ) - - if _, err := s.db.Exec(`DELETE FROM entries WHERE id=$1 AND user_id=$2`, entryID, userID); err != nil { - return fmt.Errorf(`store: unable to delete user feed entries #%d: %v`, entryID, err) - } - } - + // Since entries have a `references` on `feeds(id)` with an `on delete cascade`, + // we can simply remove the correct `feeds(id)` and postgresql will take care of deleting the + // corresponding entries. if _, err := s.db.Exec(`DELETE FROM feeds WHERE id=$1 AND user_id=$2`, feedID, userID); err != nil { return fmt.Errorf(`store: unable to delete feed #%d: %v`, feedID, err) }