oss/miniflux-v2
oss/miniflux-v2
1
0
Fork 0
mirror of https://github.com/miniflux/v2.git synced 2025-09-05 18:41:01 +00:00
Code Wiki Activity

Fix accessibility issues in modal component

Browse source 
* Fix modal aria role
* Trap focusing with tab / shift+tab inside the modal
* Restore keyboard focus when closing modal
* Automatically move keyboard focus to first focusable element unless specified otherwise
* Keyboard shortcut help modal: move keyboard focus to modal title
* Keyboard shortcut help modal: change close control from link to button
This commit is contained in:
Tuukka Ojala 2023-07-02 23:28:02 +03:00 • committed by Frédéric Guillot
parent bfb4fc1c36
commit 29a06511a9
3 changed files with 77 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

4
template/templates/common/layout.html
View file

@ -116,8 +116,8 @@
</main>
<template id="keyboard-shortcuts">
<div id="modal-left">
<a href="#" class="btn-close-modal">x</a>
<h3>{{ t "page.keyboard_shortcuts.title" }}</h3>
<button class="btn-close-modal" aria-label="Close">x</button>
<h3 tabindex="-1" id="dialog-title">{{ t "page.keyboard_shortcuts.title" }}</h3>
<div class="keyboard-shortcuts">
<p>{{ t "page.keyboard_shortcuts.subtitle.sections" }}</p>