From 2318e9011db2e8e4051e33db39c7513043a40238 Mon Sep 17 00:00:00 2001 From: jvoisin Date: Mon, 20 Jan 2025 16:17:58 +0100 Subject: [PATCH] Use proper types in app.js --- internal/ui/static/js/app.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/internal/ui/static/js/app.js b/internal/ui/static/js/app.js index 9ed90a12..405d0a85 100644 --- a/internal/ui/static/js/app.js +++ b/internal/ui/static/js/app.js @@ -71,9 +71,9 @@ function toggleMainMenu(event) { const menu = document.querySelector(".header nav ul"); const menuToggleButton = document.querySelector(".logo"); if (menu.classList.contains("js-menu-show")) { - menuToggleButton.setAttribute("aria-expanded", false); + menuToggleButton.setAttribute("aria-expanded", "false"); } else { - menuToggleButton.setAttribute("aria-expanded", true); + menuToggleButton.setAttribute("aria-expanded", "true"); } menu.classList.toggle("js-menu-show"); } @@ -274,7 +274,7 @@ function saveEntry(element, toasting) { request.withCallback(() => { element.textContent = ""; appendIconLabel(element, element.dataset.labelDone); - element.dataset.completed = true; + element.dataset.completed = "true"; if (toasting) { const iconElement = document.querySelector("template#icon-save"); showToast(element.dataset.toastDone, iconElement);