1
0
Fork 0
mirror of https://github.com/miniflux/v2.git synced 2025-07-02 16:38:37 +00:00

feat(rss): calculate hash based on item title/content for feeds without GUID and link

This commit is contained in:
Frédéric Guillot 2024-10-18 17:59:18 -07:00
parent 366928b35d
commit 191f3a7ad7
2 changed files with 38 additions and 2 deletions

View file

@ -101,10 +101,13 @@ func (r *RSSAdapter) BuildFeed(baseURL string) *model.Feed {
} }
// Generate the entry hash. // Generate the entry hash.
if item.GUID.Data != "" { switch {
case item.GUID.Data != "":
entry.Hash = crypto.Hash(item.GUID.Data) entry.Hash = crypto.Hash(item.GUID.Data)
} else if entryURL != "" { case entryURL != "":
entry.Hash = crypto.Hash(entryURL) entry.Hash = crypto.Hash(entryURL)
default:
entry.Hash = crypto.Hash(entry.Title + entry.Content)
} }
// Find CommentsURL if defined. // Find CommentsURL if defined.

View file

@ -336,6 +336,39 @@ func TestParseEntryWithoutLink(t *testing.T) {
} }
} }
func TestParseEntryWithoutLinkAndWithoutGUID(t *testing.T) {
data := `<?xml version="1.0" encoding="utf-8"?>
<rss version="2.0">
<channel>
<link>https://example.org/</link>
<item>
<title>Item 1</title>
</item>
<item>
<title>Item 2</title>
<pubDate>Wed, 02 Oct 2002 08:00:00 GMT</pubDate>
</item>
</channel>
</rss>`
feed, err := Parse("https://example.org/", bytes.NewReader([]byte(data)))
if err != nil {
t.Fatal(err)
}
if len(feed.Entries) != 2 {
t.Errorf("Incorrect number of entries, got: %d", len(feed.Entries))
}
if feed.Entries[0].Hash != "c5ddfeffb275254140796b8c080f372d65ebb1b0590e238b191f595d5fcd32ca" {
t.Errorf("Incorrect entry hash, got: %s", feed.Entries[0].Hash)
}
if feed.Entries[1].Hash != "0a937478f9bdbfca2de5cdeeb5ee7b09678a3330fc7cc5b05169a50d4516c9a3" {
t.Errorf("Incorrect entry hash, got: %s", feed.Entries[1].Hash)
}
}
func TestParseEntryWithOnlyGuidPermalink(t *testing.T) { func TestParseEntryWithOnlyGuidPermalink(t *testing.T) {
data := `<?xml version="1.0" encoding="utf-8"?> data := `<?xml version="1.0" encoding="utf-8"?>
<rss version="2.0"> <rss version="2.0">