1
0
Fork 0
mirror of https://github.com/miniflux/v2.git synced 2025-08-06 17:41:00 +00:00

feat(cookie): use SameSiteStrictMode when not using OAuth2/OIDC

This commit is contained in:
Julien Voisin 2025-07-09 04:20:24 +02:00 committed by GitHub
parent abed7b11ce
commit 135ce1d546
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -18,20 +18,26 @@ const (
// New creates a new cookie.
func New(name, value string, isHTTPS bool, path string) *http.Cookie {
return &http.Cookie{
cookie := &http.Cookie{
Name: name,
Value: value,
Path: basePath(path),
Secure: isHTTPS,
HttpOnly: true,
Expires: time.Now().Add(time.Duration(config.Opts.CleanupRemoveSessionsDays()) * 24 * time.Hour),
SameSite: http.SameSiteLaxMode,
SameSite: http.SameSiteStrictMode,
}
// OAuth doesn't work when cookies are in strict mode.
if config.Opts.OAuth2Provider() != "" {
cookie.SameSite = http.SameSiteLaxMode
}
return cookie
}
// Expired returns an expired cookie.
func Expired(name string, isHTTPS bool, path string) *http.Cookie {
return &http.Cookie{
cookie := &http.Cookie{
Name: name,
Value: "",
Path: basePath(path),
@ -39,8 +45,14 @@ func Expired(name string, isHTTPS bool, path string) *http.Cookie {
HttpOnly: true,
MaxAge: -1,
Expires: time.Date(1970, 1, 1, 0, 0, 0, 0, time.UTC),
SameSite: http.SameSiteLaxMode,
SameSite: http.SameSiteStrictMode,
}
// OAuth doesn't work when cookies are in strict mode.
if config.Opts.OAuth2Provider() != "" {
cookie.SameSite = http.SameSiteLaxMode
}
return cookie
}
func basePath(path string) string {