From 078eb39db9ac0c8ba59be98b0a56edc88f9908e6 Mon Sep 17 00:00:00 2001 From: Julien Voisin Date: Fri, 1 Aug 2025 03:03:53 +0200 Subject: [PATCH] refactor(config): don't check random.Read's return value As stated in the documentation: > Read calls io.ReadFull on Reader and crashes the program irrecoverably if an error is returned. The default Reader uses operating system APIs that are documented to never return an error on all but legacy Linux systems. --- internal/config/parser.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/internal/config/parser.go b/internal/config/parser.go index 0d92346c..14b01dae 100644 --- a/internal/config/parser.go +++ b/internal/config/parser.go @@ -165,9 +165,7 @@ func (p *parser) parseLines(lines []string) (err error) { p.opts.mediaProxyResourceTypes = parseStringList(value, []string{defaultMediaResourceTypes}) case "MEDIA_PROXY_PRIVATE_KEY": randomKey := make([]byte, 16) - if _, err := rand.Read(randomKey); err != nil { - return fmt.Errorf("config: unable to generate random key: %w", err) - } + rand.Read(randomKey) p.opts.mediaProxyPrivateKey = parseBytes(value, randomKey) case "MEDIA_PROXY_CUSTOM_URL": p.opts.mediaProxyCustomURL = parseString(value, defaultMediaProxyURL)