1
0
Fork 0
mirror of https://github.com/miniflux/v2.git synced 2025-06-27 16:36:00 +00:00
miniflux-v2/internal/reader/sanitizer/sanitizer.go

487 lines
12 KiB
Go
Raw Normal View History

// SPDX-FileCopyrightText: Copyright The Miniflux Authors. All rights reserved.
// SPDX-License-Identifier: Apache-2.0
2017-11-19 21:10:04 -08:00
package sanitizer // import "miniflux.app/v2/internal/reader/sanitizer"
2017-11-19 21:10:04 -08:00
import (
"io"
"net/url"
"slices"
"strconv"
2017-11-19 21:10:04 -08:00
"strings"
"miniflux.app/v2/internal/config"
"miniflux.app/v2/internal/reader/urlcleaner"
"miniflux.app/v2/internal/urllib"
2017-11-25 18:08:59 -08:00
2017-11-19 21:10:04 -08:00
"golang.org/x/net/html"
)
var (
tagAllowList = map[string][]string{
"a": {"href", "title", "id"},
"abbr": {"title"},
"acronym": {"title"},
"aside": {},
"audio": {"src"},
"blockquote": {},
2025-03-06 18:23:27 +01:00
"b": {},
"br": {},
"caption": {},
"cite": {},
"code": {},
"dd": {"id"},
"del": {},
"dfn": {},
"dl": {"id"},
"dt": {"id"},
"em": {},
"figcaption": {},
"figure": {},
"h1": {"id"},
"h2": {"id"},
"h3": {"id"},
"h4": {"id"},
"h5": {"id"},
"h6": {"id"},
2024-12-27 13:51:22 -08:00
"hr": {},
"iframe": {"width", "height", "frameborder", "src", "allowfullscreen"},
"img": {"alt", "title", "src", "srcset", "sizes", "width", "height"},
"ins": {},
"kbd": {},
"li": {"id"},
"ol": {"id"},
"p": {},
"picture": {},
"pre": {},
"q": {"cite"},
"rp": {},
"rt": {},
"rtc": {},
"ruby": {},
"s": {},
"samp": {},
"source": {"src", "type", "srcset", "sizes", "media"},
"strong": {},
"sub": {},
"sup": {"id"},
"table": {},
"td": {"rowspan", "colspan"},
"tfoot": {},
"th": {"rowspan", "colspan"},
"thead": {},
"time": {"datetime"},
"tr": {},
2025-03-06 18:16:22 +01:00
"u": {},
"ul": {"id"},
"var": {},
"video": {"poster", "height", "width", "src"},
"wbr": {},
}
)
2017-11-19 21:10:04 -08:00
// Sanitize returns safe HTML.
func Sanitize(baseURL, input string) string {
var buffer strings.Builder
2017-11-19 21:10:04 -08:00
var tagStack []string
var parentTag string
var blockedStack []string
2017-11-19 21:10:04 -08:00
tokenizer := html.NewTokenizer(strings.NewReader(input))
2017-11-19 21:10:04 -08:00
for {
if tokenizer.Next() == html.ErrorToken {
err := tokenizer.Err()
if err == io.EOF {
return buffer.String()
}
return ""
}
token := tokenizer.Token()
2024-12-07 22:59:00 +01:00
tagName := token.DataAtom.String()
2017-11-19 21:10:04 -08:00
switch token.Type {
case html.TextToken:
if len(blockedStack) > 0 {
continue
}
// An iframe element never has fallback content.
// See https://www.w3.org/TR/2010/WD-html5-20101019/the-iframe-element.html#the-iframe-element
if parentTag == "iframe" {
continue
}
buffer.WriteString(token.String())
2017-11-19 21:10:04 -08:00
case html.StartTagToken:
parentTag = tagName
2017-11-19 21:10:04 -08:00
if isPixelTracker(tagName, token.Attr) {
continue
}
if isBlockedTag(tagName) || slices.ContainsFunc(token.Attr, func(attr html.Attribute) bool { return attr.Key == "hidden" }) {
blockedStack = append(blockedStack, tagName)
continue
}
2017-11-19 21:10:04 -08:00
if len(blockedStack) == 0 && isValidTag(tagName) {
attrNames, htmlAttributes := sanitizeAttributes(baseURL, tagName, token.Attr)
2017-11-19 21:10:04 -08:00
if hasRequiredAttributes(tagName, attrNames) {
if len(attrNames) > 0 {
// Rewrite the start tag with allowed attributes.
2017-11-19 21:10:04 -08:00
buffer.WriteString("<" + tagName + " " + htmlAttributes + ">")
} else {
// Rewrite the start tag without any attributes.
buffer.WriteString("<" + tagName + ">")
2017-11-19 21:10:04 -08:00
}
tagStack = append(tagStack, tagName)
}
}
case html.EndTagToken:
if len(blockedStack) == 0 {
if isValidTag(tagName) && slices.Contains(tagStack, tagName) {
buffer.WriteString("</" + tagName + ">")
}
} else {
if blockedStack[len(blockedStack)-1] == tagName {
blockedStack = blockedStack[:len(blockedStack)-1]
}
2017-11-19 21:10:04 -08:00
}
case html.SelfClosingTagToken:
if isPixelTracker(tagName, token.Attr) {
continue
}
if len(blockedStack) == 0 && isValidTag(tagName) {
2017-11-19 21:10:04 -08:00
attrNames, htmlAttributes := sanitizeAttributes(baseURL, tagName, token.Attr)
if hasRequiredAttributes(tagName, attrNames) {
if len(attrNames) > 0 {
buffer.WriteString("<" + tagName + " " + htmlAttributes + "/>")
} else {
buffer.WriteString("<" + tagName + "/>")
2017-11-19 21:10:04 -08:00
}
}
}
}
}
}
2017-11-25 18:08:59 -08:00
func sanitizeAttributes(baseURL, tagName string, attributes []html.Attribute) ([]string, string) {
var htmlAttrs, attrNames []string
2017-11-19 21:10:04 -08:00
var err error
var isImageLargerThanLayout bool
var isAnchorLink bool
if tagName == "img" {
imgWidth := getIntegerAttributeValue("width", attributes)
isImageLargerThanLayout = imgWidth > 750
}
2017-11-19 21:10:04 -08:00
for _, attribute := range attributes {
value := attribute.Val
if !isValidAttribute(tagName, attribute.Key) {
continue
}
if (tagName == "img" || tagName == "source") && attribute.Key == "srcset" {
value = sanitizeSrcsetAttr(baseURL, value)
}
if tagName == "img" && (attribute.Key == "width" || attribute.Key == "height") {
2024-12-07 23:00:20 +01:00
if isImageLargerThanLayout || !isPositiveInteger(value) {
continue
}
}
2017-11-19 21:10:04 -08:00
if isExternalResourceAttribute(attribute.Key) {
switch {
case tagName == "iframe":
if !isValidIframeSource(baseURL, attribute.Val) {
continue
}
value = rewriteIframeURL(attribute.Val)
case tagName == "img" && attribute.Key == "src" && isValidDataAttribute(attribute.Val):
2020-10-14 22:19:05 -07:00
value = attribute.Val
case tagName == "a" && attribute.Key == "href" && strings.HasPrefix(attribute.Val, "#"):
value = attribute.Val
isAnchorLink = true
default:
value, err = urllib.AbsoluteURL(baseURL, value)
2017-11-19 21:10:04 -08:00
if err != nil {
continue
}
if !hasValidURIScheme(value) || isBlockedResource(value) {
2017-11-19 21:10:04 -08:00
continue
}
if cleanedURL, err := urlcleaner.RemoveTrackingParameters(value); err == nil {
value = cleanedURL
}
2017-11-19 21:10:04 -08:00
}
}
attrNames = append(attrNames, attribute.Key)
htmlAttrs = append(htmlAttrs, attribute.Key+`="`+html.EscapeString(value)+`"`)
2017-11-19 21:10:04 -08:00
}
if !isAnchorLink {
extraAttrNames, extraHTMLAttributes := getExtraAttributes(tagName)
if len(extraAttrNames) > 0 {
attrNames = append(attrNames, extraAttrNames...)
htmlAttrs = append(htmlAttrs, extraHTMLAttributes...)
}
2017-11-19 21:10:04 -08:00
}
return attrNames, strings.Join(htmlAttrs, " ")
}
func getExtraAttributes(tagName string) ([]string, []string) {
switch tagName {
case "a":
2017-11-19 21:10:04 -08:00
return []string{"rel", "target", "referrerpolicy"}, []string{`rel="noopener noreferrer"`, `target="_blank"`, `referrerpolicy="no-referrer"`}
case "video", "audio":
2017-11-19 21:10:04 -08:00
return []string{"controls"}, []string{"controls"}
case "iframe":
return []string{"sandbox", "loading"}, []string{`sandbox="allow-scripts allow-same-origin allow-popups allow-popups-to-escape-sandbox"`, `loading="lazy"`}
case "img":
return []string{"loading"}, []string{`loading="lazy"`}
default:
return nil, nil
2017-11-19 21:10:04 -08:00
}
}
func isValidTag(tagName string) bool {
2024-12-07 23:01:59 +01:00
_, ok := tagAllowList[tagName]
return ok
2017-11-19 21:10:04 -08:00
}
func isValidAttribute(tagName, attributeName string) bool {
if attributes, ok := tagAllowList[tagName]; ok {
return slices.Contains(attributes, attributeName)
2017-11-19 21:10:04 -08:00
}
return false
}
func isExternalResourceAttribute(attribute string) bool {
switch attribute {
case "src", "href", "poster", "cite":
return true
default:
return false
}
}
func isPixelTracker(tagName string, attributes []html.Attribute) bool {
if tagName != "img" {
return false
}
hasHeight := false
hasWidth := false
2017-11-19 21:10:04 -08:00
for _, attribute := range attributes {
if attribute.Val == "1" {
switch attribute.Key {
case "height":
2017-11-19 21:10:04 -08:00
hasHeight = true
case "width":
2017-11-19 21:10:04 -08:00
hasWidth = true
}
}
}
return hasHeight && hasWidth
2017-11-19 21:10:04 -08:00
}
func hasRequiredAttributes(tagName string, attributes []string) bool {
switch tagName {
case "a":
return slices.Contains(attributes, "href")
case "iframe":
return slices.Contains(attributes, "src")
case "source", "img":
return slices.Contains(attributes, "src") || slices.Contains(attributes, "srcset")
default:
return true
2017-11-19 21:10:04 -08:00
}
}
// See https://www.iana.org/assignments/uri-schemes/uri-schemes.xhtml
func hasValidURIScheme(src string) bool {
2017-11-19 21:10:04 -08:00
whitelist := []string{
"apt:",
"bitcoin:",
"callto:",
"dav:",
"davs:",
2017-11-19 21:10:04 -08:00
"ed2k://",
"facetime://",
"feed:",
2017-11-19 21:10:04 -08:00
"ftp://",
"geo:",
2017-11-19 21:10:04 -08:00
"gopher://",
"git://",
"http://",
"https://",
"irc://",
"irc6://",
"ircs://",
"itms://",
"itms-apps://",
"magnet:",
"mailto:",
"news:",
"nntp:",
2017-11-19 21:10:04 -08:00
"rtmp://",
"sip:",
"sips:",
"skype:",
"spotify:",
2017-11-19 21:10:04 -08:00
"ssh://",
"sftp://",
"steam://",
"svn://",
"svn+ssh://",
"tel:",
2017-11-19 21:10:04 -08:00
"webcal://",
"xmpp:",
// iOS Apps
"opener://", // https://www.opener.link
"hack://", // https://apps.apple.com/it/app/hack-for-hacker-news-reader/id1464477788?l=en-GB
2017-11-19 21:10:04 -08:00
}
return slices.ContainsFunc(whitelist, func(prefix string) bool {
return strings.HasPrefix(src, prefix)
})
2017-11-19 21:10:04 -08:00
}
func isBlockedResource(src string) bool {
2017-11-19 21:10:04 -08:00
blacklist := []string{
"feedsportal.com",
"api.flattr.com",
"stats.wordpress.com",
"twitter.com/share",
"feeds.feedburner.com",
}
return slices.ContainsFunc(blacklist, func(element string) bool {
return strings.Contains(src, element)
})
2017-11-19 21:10:04 -08:00
}
func isValidIframeSource(baseURL, src string) bool {
2017-11-19 21:10:04 -08:00
whitelist := []string{
"bandcamp.com",
"cdn.embedly.com",
"player.bilibili.com",
"player.twitch.tv",
"player.vimeo.com",
"soundcloud.com",
"vk.com",
"w.soundcloud.com",
"dailymotion.com",
"youtube-nocookie.com",
"youtube.com",
2025-05-03 02:25:17 +03:00
"open.spotify.com",
2017-11-19 21:10:04 -08:00
}
domain := urllib.Domain(src)
2017-11-19 21:10:04 -08:00
// allow iframe from same origin
if urllib.Domain(baseURL) == domain {
return true
}
2022-01-06 05:43:03 +01:00
// allow iframe from custom invidious instance
if config.Opts.InvidiousInstance() == domain {
2022-01-06 05:43:03 +01:00
return true
}
return slices.Contains(whitelist, strings.TrimPrefix(domain, "www."))
2017-11-19 21:10:04 -08:00
}
func rewriteIframeURL(link string) string {
u, err := url.Parse(link)
if err != nil {
return link
}
switch strings.TrimPrefix(u.Hostname(), "www.") {
case "youtube.com":
if strings.HasPrefix(u.Path, "/embed/") {
if len(u.RawQuery) > 0 {
return config.Opts.YouTubeEmbedUrlOverride() + strings.TrimPrefix(u.Path, "/embed/") + "?" + u.RawQuery
}
return config.Opts.YouTubeEmbedUrlOverride() + strings.TrimPrefix(u.Path, "/embed/")
}
case "player.vimeo.com":
// See https://help.vimeo.com/hc/en-us/articles/12426260232977-About-Player-parameters
if strings.HasPrefix(u.Path, "/video/") {
if len(u.RawQuery) > 0 {
return link + "&dnt=1"
}
return link + "?dnt=1"
}
}
return link
}
func isBlockedTag(tagName string) bool {
blacklist := []string{
"noscript",
"script",
"style",
}
return slices.Contains(blacklist, tagName)
}
func sanitizeSrcsetAttr(baseURL, value string) string {
imageCandidates := ParseSrcSetAttribute(value)
for _, imageCandidate := range imageCandidates {
2024-12-07 23:07:00 +01:00
if absoluteURL, err := urllib.AbsoluteURL(baseURL, imageCandidate.ImageURL); err == nil {
imageCandidate.ImageURL = absoluteURL
}
}
return imageCandidates.String()
}
func isValidDataAttribute(value string) bool {
var dataAttributeAllowList = []string{
"data:image/avif",
"data:image/apng",
"data:image/png",
"data:image/svg",
"data:image/svg+xml",
"data:image/jpg",
"data:image/jpeg",
"data:image/gif",
"data:image/webp",
}
return slices.ContainsFunc(dataAttributeAllowList, func(prefix string) bool {
return strings.HasPrefix(value, prefix)
})
}
func isPositiveInteger(value string) bool {
if number, err := strconv.Atoi(value); err == nil {
return number > 0
}
return false
}
2024-12-07 23:07:28 +01:00
func getIntegerAttributeValue(name string, attributes []html.Attribute) int {
for _, attribute := range attributes {
if attribute.Key == name {
2024-12-07 23:07:28 +01:00
number, _ := strconv.Atoi(attribute.Val)
return number
}
}
2024-12-07 23:07:28 +01:00
return 0
}