* Upgrade client active object mgr tests to Catch2
In addition to invoking Catch2's test runner after Minetest's homemade
runner, this refactors the tests to follow the DRY principle, and gives
them expressive names and clear assertions. Catch2 is already bundled
with Minetest, so there are no added dependencies.
* Increment failed modules count for Catch2 tests
* Respect --test-module option for Catch2 tests
* Improve Catch2 --test-module behavior
This switches infostream to rawstream so that test runner output is
displayed, and returns the correct boolean depending on the results. The
tests are now found by setting the configuration instead of invoking the
command line parser.
* Test uniqueness of all IDS instead of just one
Co-Authored-By: Lars Müller <appgurulars@gmx.de>
* Include Catch2 test run in timing and logging
* Flush std::cout after printing Catch results
* Increment total tests run instead of hardcoding to 1
* Flush stderr before printing to stdout
It's necessary to flush stderr before printing to stdout in adition to
flushing stdout before printing to stderr, to make sure all output is
ordered correctly.
* Make Catch write to rawstream
---------
Co-authored-by: Lars Müller <appgurulars@gmx.de>
Fixes a regression caused by 4245a760
'moveItemSomewhere' attempted to add a leftover stack to an empty stack, resulting
in an empty name with non-0 ItemStack count.
The recently added ioctl use is reported as a false-positive by valgrind.
I tried moving it to different compilers/versions two times and only
hit further issues that were valgrind's fault.
Also includes a tiny fix.
Use win32 APIs to write the temporary file before copying to the final
destination. Because we've observed the final file being empty, we
suspect that std::ostream::flush is not flushing.
Also add a test for it.
This partially reverts commit d57c936b08.
The reverted commit prevented recognition of key combinations.
It correctly changed a test case to no longer use “KEY_NUMPAD_5”.
Several keyboard layouts use a key combination to input a “+” (e.g. Neo2);
therefore some users could no longer input “+” to increase the view range.
Co-authored-by: savilli <78875209+savilli@users.noreply.github.com>
