oss/luanti
oss/luanti
1
0
Fork 0
mirror of https://github.com/luanti-org/luanti.git synced 2025-06-27 16:36:03 +00:00
Code Wiki Activity

Fix various copy instead of const ref reported by cppcheck (part 3) (#5616)

Browse source 
* Also remove 2 non declared but defined functions
* Make some functions around const ref changes const
This commit is contained in:
Loïc Blot 2017-04-20 00:12:52 +02:00 • committed by GitHub
parent f3fe62a0bf
commit f98bbe193e
25 changed files with 182 additions and 182 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/script/cpp_api/s_async.cpp
View file

@ -100,7 +100,8 @@ void AsyncEngine::initialize(unsigned int numEngines)
}
/******************************************************************************/
unsigned int AsyncEngine::queueAsyncJob(std::string func, std::string params)
unsigned int AsyncEngine::queueAsyncJob(const std::string &func,
const std::string &params)
{
jobQueueMutex.lock();
LuaJobInfo toAdd;
@ -124,7 +125,6 @@ LuaJobInfo AsyncEngine::getJob()
jobQueueMutex.lock();
LuaJobInfo retval;
retval.valid = false;
if (!jobQueue.empty()) {
retval = jobQueue.front();
@ -137,7 +137,7 @@ LuaJobInfo AsyncEngine::getJob()
}
/******************************************************************************/
void AsyncEngine::putJobResult(LuaJobInfo result)
void AsyncEngine::putJobResult(const LuaJobInfo &result)
{
resultQueueMutex.lock();
resultQueue.push_back(result);
@ -264,7 +264,7 @@ void* AsyncWorkerThread::run()
// Wait for job
LuaJobInfo toProcess = jobDispatcher->getJob();
if (toProcess.valid == false || stopRequested()) {
if (!toProcess.valid || stopRequested()) {
continue;
}

15
src/script/cpp_api/s_async.h
View file

@ -38,7 +38,16 @@ class AsyncEngine;
// Declarations
// Data required to queue a job
struct LuaJobInfo {
struct LuaJobInfo
{
LuaJobInfo() :
serializedFunction(""),
serializedParams(""),
serializedResult(""),
id(0),
valid(false)
{}
// Function to be called in async environment
std::string serializedFunction;
// Parameter to be passed to function
@ -89,7 +98,7 @@ public:
* @param params Serialized parameters
* @return jobid The job is queued
*/
unsigned int queueAsyncJob(std::string func, std::string params);
unsigned int queueAsyncJob(const std::string &func, const std::string &params);
/**
* Engine step to process finished jobs
@ -116,7 +125,7 @@ protected:
* Put a Job result back to result queue
* @param result result of completed job
*/
void putJobResult(LuaJobInfo result);
void putJobResult(const LuaJobInfo &result);
/**
* Initialize environment with current registred functions