oss/luanti
oss/luanti
1
0
Fork 0
mirror of https://github.com/luanti-org/luanti.git synced 2025-08-16 18:01:40 +00:00
Code Wiki Activity

Fix various copy instead of const ref reported by cppcheck (part 3) (#5616)

Browse source 
* Also remove 2 non declared but defined functions
* Make some functions around const ref changes const
This commit is contained in:
Loïc Blot 2017-04-20 00:12:52 +02:00 • committed by GitHub
parent f3fe62a0bf
commit f98bbe193e
25 changed files with 182 additions and 182 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/network/connection.h
View file

@ -383,7 +383,7 @@ struct OutgoingPacket
bool reliable;
bool ack;
OutgoingPacket(u16 peer_id_, u8 channelnum_, SharedBuffer<u8> data_,
OutgoingPacket(u16 peer_id_, u8 channelnum_, const SharedBuffer<u8> &data_,
bool reliable_,bool ack_=false):
peer_id(peer_id_),
channelnum(channelnum_),
@ -448,7 +448,7 @@ struct ConnectionCommand
reliable = reliable_;
}
void ack(u16 peer_id_, u8 channelnum_, SharedBuffer<u8> data_)
void ack(u16 peer_id_, u8 channelnum_, const SharedBuffer<u8> &data_)
{
type = CONCMD_ACK;
peer_id = peer_id_;
@ -457,7 +457,7 @@ struct ConnectionCommand
reliable = false;
}
void createPeer(u16 peer_id_, SharedBuffer<u8> data_)
void createPeer(u16 peer_id_, const SharedBuffer<u8> &data_)
{
type = CONCMD_CREATE_PEER;
peer_id = peer_id_;
@ -467,7 +467,7 @@ struct ConnectionCommand
raw = true;
}
void disableLegacy(u16 peer_id_, SharedBuffer<u8> data_)
void disableLegacy(u16 peer_id_, const SharedBuffer<u8> &data_)
{
type = CONCMD_DISABLE_LEGACY;
peer_id = peer_id_;
@ -874,7 +874,7 @@ struct ConnectionEvent
return "Invalid ConnectionEvent";
}
void dataReceived(u16 peer_id_, SharedBuffer<u8> data_)
void dataReceived(u16 peer_id_, const SharedBuffer<u8> &data_)
{
type = CONNEVENT_DATA_RECEIVED;
peer_id = peer_id_;