oss/luanti
oss/luanti
1
0
Fork 0
mirror of https://github.com/luanti-org/luanti.git synced 2025-08-16 18:01:40 +00:00
Code Wiki Activity

Fix various copy instead of const ref reported by cppcheck (#5615)

Browse source 
* Also remove InventoryList::peekItem unused function
* Fix some post increment to preincrement reported by cppcheck
This commit is contained in:
Loïc Blot 2017-04-19 23:02:07 +02:00 • committed by GitHub
parent cfe0291b13
commit f3fe62a0bf
13 changed files with 46 additions and 68 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/inventory.h
View file

@ -173,7 +173,7 @@ struct ItemStack
class InventoryList
{
public:
InventoryList(std::string name, u32 size, IItemDefManager *itemdef);
InventoryList(const std::string &name, u32 size, IItemDefManager *itemdef);
~InventoryList();
void clearItems();
void setSize(u32 newsize);
@ -239,9 +239,6 @@ public:
// Returns empty item if couldn't take any.
ItemStack takeItem(u32 i, u32 takecount);
// Similar to takeItem, but keeps the slot intact.
ItemStack peekItem(u32 i, u32 peekcount) const;
// Move an item to a different list (or a different stack in the same list)
// count is the maximum number of items to move (0 for everything)
// returns number of moved items
@ -254,8 +251,8 @@ public:
private:
std::vector<ItemStack> m_items;
u32 m_size, m_width;
std::string m_name;
u32 m_size, m_width;
IItemDefManager *m_itemdef;
};