oss/luanti
oss/luanti
1
0
Fork 0
mirror of https://github.com/luanti-org/luanti.git synced 2025-08-11 17:51:04 +00:00
Code Wiki Activity

LINT: add clang-tidy step (#6295)

Browse source 
* Implement new travis clang-tidy build step

* This step enable some rules and enforce one rule as error
* This permits to have some C++ quality rules based on clang & clang contributor guidelines

* Fix clang-tidy reported problems on push_back -> emplace_back
This commit is contained in:
Loïc Blot 2018-04-01 23:57:55 +02:00 • committed by GitHub
parent 93eb0794d6
commit d88c4e1822
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
8 changed files with 319 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/gui/guiEditBoxWithScrollbar.cpp
View file

@ -743,7 +743,7 @@ void GUIEditBoxWithScrollBar::draw()
if (m_passwordbox) {
if (m_broken_text.size() != 1) {
m_broken_text.clear();
m_broken_text.push_back(core::stringw());
m_broken_text.emplace_back();
}
if (m_broken_text[0].size() != Text.size()){
m_broken_text[0] = Text;

8
src/script/cpp_api/s_env.cpp
View file

@ -116,12 +116,12 @@ void ScriptApiEnv::initializeEnvironment(ServerEnvironment *env)
while (lua_next(L, table)) {
// key at index -2 and value at index -1
luaL_checktype(L, -1, LUA_TSTRING);
trigger_contents.push_back(lua_tostring(L, -1));
trigger_contents.emplace_back(lua_tostring(L, -1));
// removes value, keeps key for next iteration
lua_pop(L, 1);
}
} else if (lua_isstring(L, -1)) {
trigger_contents.push_back(lua_tostring(L, -1));
trigger_contents.emplace_back(lua_tostring(L, -1));
}
lua_pop(L, 1);
@ -133,12 +133,12 @@ void ScriptApiEnv::initializeEnvironment(ServerEnvironment *env)
while (lua_next(L, table)) {
// key at index -2 and value at index -1
luaL_checktype(L, -1, LUA_TSTRING);
required_neighbors.push_back(lua_tostring(L, -1));
required_neighbors.emplace_back(lua_tostring(L, -1));
// removes value, keeps key for next iteration
lua_pop(L, 1);
}
} else if (lua_isstring(L, -1)) {
required_neighbors.push_back(lua_tostring(L, -1));
required_neighbors.emplace_back(lua_tostring(L, -1));
}
lua_pop(L, 1);